Review main Merged

64506[TASK] Provide information about mandatory `uid` field in PHPDoc

Thomas Löffler CR +2 V +2 Easy +10 −5 updated 10/13/20, 09:45

Commit message

A couple of functions in PageRepository allow to define the fields
to be selected. Because the `uid` is used internally to further
process the selected row, this field is mandatory and must be
present in a custom fields list.

This fact is now documented in all corresponding PHPDoc blocks.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Thomas Löffler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Thomas Löffler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 2232

Show 57 earlier messages
  1. Thomas Löffler uploaded patch set 1 05/16/20, 21:48

  2. TYPO3com voted on patch set 1 V +1 05/16/20, 22:01 Completed build in 12m 52s on Sat, 16 May, 10:01 PM Test Summary: 73733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3409

  3. Oli Bartsch commented on patch set 1 05/17/20, 09:22

    The patch works for me. However now the pages rows contain the `uid` field which was not requested by calling the method. It's clear that we internally need this field for further processing but we may want to omit it in the return if it was not explicitly requested.

    PageRepository.php:767 Unresolved

    [EA] 'in_array(...)' would fit more here (clarifies intention, improves maintainability).
  4. Thomas Löffler uploaded patch set 2 05/17/20, 14:34

  5. Thomas Löffler commented on patch set 2 05/17/20, 14:37

    > Patch Set 1: > > (1 comment) > > The patch works for me. However now the pages rows contain the `uid` field which was not requested by calling the method. It's clear that we internally need this field for further processing but we may want to omit it in the return if it was not explicitly requested. I don't think that there is a case where the UID is not wanted in the array. It would complicate the code imho.
  6. Thomas Löffler updated the commit message in patch set 3 05/17/20, 14:38

  7. TYPO3com voted on patch set 2 V +1 05/17/20, 14:46 Completed build in 11m 50s on Sun, 17 May, 02:46 PM Test Summary: 73733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3413

  1. TYPO3com voted on patch set 3 V -1 05/17/20, 14:52 Completed build in 14m 26s on Sun, 17 May, 02:52 PM Test Summary: 1 of 74217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3414

  2. TYPO3com voted on patch set 3 V +1 05/18/20, 06:38 Completed build in 16h 15m 00s on Mon, 18 May, 06:38 AM Test Summary: 73733 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3414

  3. Oli Bartsch uploaded patch set 4 05/18/20, 08:05

  4. Oli Bartsch commented on patch set 4 V +1 CR +1 05/18/20, 08:06

    > Patch Set 2: > > > Patch Set 1: > > > > (1 comment) > > > > The patch works for me. However now the pages rows contain the `uid` field which was not requested by calling the method. It's clear that we internally need this field for further processing but we may want to omit it in the return if it was not explicitly requested. > > I don't think that there is a case where the UID is not wanted in the array. It would complicate the code imho. Seems reasonable to me. Thanks.
  5. TYPO3com voted on patch set 4 V -1 05/18/20, 08:20 Completed build in 14m 50s on Mon, 18 May, 08:20 AM Test Summary: 1 of 74217 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3421

  6. TYPO3com voted on patch set 4 V +1 05/18/20, 08:39 Completed build in 12m 51s on Mon, 18 May, 08:39 AM Test Summary: 73787 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-3423

  7. Benjamin Franzke voted on patch set 4 CR +1 05/18/20, 21:12

  8. Benni Mack updated the commit message in patch set 5 05/25/20, 18:52

  9. Oli Bartsch uploaded patch set 6 09/02/20, 13:28

  10. Oli Bartsch voted on patch set 6 V +1 CR +1 09/02/20, 13:31

  11. TYPO3com voted on patch set 6 V +1 09/02/20, 13:40 Completed build in 11m 56s on Wed, 2 Sep, 01:40 PM Test Summary: 73170 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5143

  12. Benni Mack updated the commit message in patch set 7 09/02/20, 14:11

  13. Oli Bartsch voted on patch set 7 V +1 CR +1 09/02/20, 14:15

  14. TYPO3com voted on patch set 7 V -1 09/02/20, 14:23 Completed build in 11m 53s on Wed, 2 Sep, 02:23 PM Test Summary: 1 of 73655 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5144

  15. TYPO3com voted on patch set 7 V +1 09/02/20, 14:46 Completed build in 13m 37s on Wed, 2 Sep, 02:46 PM Test Summary: 73186 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5146

  16. Anja Leichsenring voted on patch set 7 V +1 CR +1 09/02/20, 17:43

  17. Wouter Wolters voted on patch set 7 CR +1 09/02/20, 17:51

  18. Jörg Bösche voted on patch set 7 V +1 CR +1 09/07/20, 08:27

  19. Benni Mack commented on patch set 7 CR -1 09/07/20, 16:16

    @Thomas: Either it's the extension owners' fault (as you described), or we need to adapt ALL places in PageRepository where $fields can be set from external. Otherwise I'd say we should adapt the PHP doc comments $fields to explain what extension authors should do.
  20. Oli Bartsch uploaded patch set 8 10/13/20, 08:42

  21. TYPO3com voted on patch set 8 V +1 10/13/20, 08:56 Completed build in 13m 18s on Tue, 13 Oct, 08:56 AM Test Summary: 73716 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6464

  22. Thomas Löffler voted on patch set 8 V +1 CR +1 10/13/20, 09:30

  23. Oli Bartsch voted on patch set 8 V +1 CR +1 10/13/20, 09:33

  24. Benni Mack voted on patch set 8 V +2 CR +2 10/13/20, 09:45

  25. Benni Mack merged patch set 9 10/13/20, 09:45