Review main Merged Breaking

64593[!!!][TASK] Remove deprecated functionality in GeneralUtility

Benni Mack CR +2 V +2 Hard +50 −665 updated 05/29/20, 10:59

Commit message

The following deprecated methods are now removed:

- \TYPO3\CMS\Core\Utility\GeneralUtility::compressIPv6
- \TYPO3\CMS\Core\Utility\GeneralUtility::flushDirectory
- \TYPO3\CMS\Core\Utility\GeneralUtility::getApplicationContext
- \TYPO3\CMS\Core\Utility\GeneralUtility::idnaEncode
- \TYPO3\CMS\Core\Utility\GeneralUtility::IPv6Hex2Bin
- \TYPO3\CMS\Core\Utility\GeneralUtility::IPv6Bin2Hex
- \TYPO3\CMS\Core\Utility\GeneralUtility::isRunningOnCgiServerApi
- \TYPO3\CMS\Core\Utility\GeneralUtility::linkThisUrl
- \TYPO3\CMS\Core\Utility\GeneralUtility::milliseconds
- \TYPO3\CMS\Core\Utility\GeneralUtility::presetApplicationContext
- \TYPO3\CMS\Core\Utility\GeneralUtility::resetApplicationContext
- \TYPO3\CMS\Core\Utility\GeneralUtility::verifyFilenameAgainstDenyPattern

In addition, makeInstanceService requires the third parameter to be array
instead of string or array.

The method "getUrl()" now only accepts one argument.

In addition, the testing framework is raised to 6.3.1 to not use
the unneeded methods anymore.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9