Review main Merged Breaking

64603[!!!][TASK] Remove support for deprecated CLI command configuration

Benjamin Franzke CR +2 V +2 Hard +29 −583 updated 05/31/20, 06:37

Commit message

Configuration via Commands.php had been superseded by tag based
DI service configuration which allowed to configure DI and dependencies
for CLI commands in one place.

The CommandRegistry is refactored as the runtime merging logic
can now be dropped and handled in addLazyCommand – which is called
by the symfony DI generated factory – instead.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 11