Review 10.4 Merged

64633[TASK] Avoid usages of TYPO3_MODE

Benjamin Franzke CR +2 V +2 Normal +62 −22 updated 06/02/20, 17:05

Commit message

All code that is using the constant TYPO3_MODE is hard to test,
as this needs to be encapsulated into various places. All testing framework
places run with TYPO3_MODE=FE which makes it impossible to even
consider making parts of the testing framework compatible running a pure
Frontend-based request in the future.

On top, the constant covers up cross-dependency between core dependencies
(whereas $GLOBALS[TSFE]->fe_user is actually a dependency to EXT:frontend).

Another testing-helper in Extbase's EnvironmentService allows to switch
within Extbase to simulate Frontend behaviour.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 10