Review main Merged

64655[BUGFIX] Re-allow pages with a trailing slash

Benni Mack CR +2 V +2 Normal +58 −12 updated 06/01/21, 18:43

Commit message

This change enables the usage of pages containing a
trailing slash in their "slug" like "/my-page/subpage/"
to be working, and modifies tests to cover this use-case.

The main routing first fetches all records including the trailing slash
(= also fetches pages with a trailing slash in their slug).

The symfony routing then checks for e.g. "/my-page/" at the very end, but will fail
if the page was named "/my-page", and then re-runs the symfony routing
to find the "/my-page" request (same behavior as before).

This change therefore solves two issues:
1. Pages with a slug with a trailing slash are properly resolved
2. Pages with a slug with trailing slash can be also called via "/my-page" and (new)
  pages without a trailing slash can be called WITH the trailing slash (as before)
  keeping maximum backwards-compatibility with RealURL logic.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6