Review main Merged Breaking

64660[!!!][TASK] Remove CSS/JS inclusion via PHP in TSFE

Benni Mack CR +2 V +2 Normal +78 −113 updated 06/05/20, 16:03

Commit message

TypoScriptFrontendController has had functionality to dynamically
load JavaScript and CSS code, also in non-cacheable (USER_INT) content.

This has been largely superseded via the AssetCollector API and
PageRenderer API which is built in a way to deal with non-cacheable
and cacheable content with proper method calls.

For this reason, the legacy functionality is removed:
* TSFE->setJS (used via TSFE->setJS('openpic') in core)
* TSFE->additionalJavaScript
* TSFE->additionalCSS
* TSFE->JSCode
* TSFE->inlineJS

Although all methods and properties have been marked as internal
in TYPO3 v10, a Breaking RST is still added.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7