Review 10.4 Merged

64799[TASK] Avoid $GLOBALS[TYPO3_REQUEST] in TSFE

Frank Nägler CR +2 V +2 Normal +51 −41 updated 06/05/20, 14:34

Commit message

In order to reduce the amount of accessing
globals in the future, and especially TYPO3_REQUEST
which was born because of missing structure
of TYPO3 Core, the currrent request object is now
handed in (optionally) to methods, to work directly
with them in TSFE context.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
  • Verified V +2 Done
    • Frank Nägler +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 35

  1. Frank Nägler commented on patch set 1 06/05/20, 13:44

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 06/05/20, 14:07 Completed build in 23m 27s on Fri, 5 Jun, 02:07 PM Test Summary: 1 of 74301 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-33

  3. TYPO3com voted on patch set 1 V +1 06/05/20, 14:34 Completed build in 1h 13m 21s on Fri, 5 Jun, 02:34 PM Test Summary: 73817 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-33

  4. Frank Nägler voted on patch set 1 V +2 CR +2 06/05/20, 14:34

  5. Frank Nägler merged patch set 2 06/05/20, 14:34