Review main Merged

64851[TASK] Update phpstan to at least 0.12.37

Alexander Schnitzler CR +2 V +2 Normal +146 −34 updated 09/23/20, 18:53

Commit message

Updating phpstan to version 0.12.37 lets phpstan benefit from
static reflection which does no longer come with the need to
load analyzed classes and use the native reflection api of php.
Instead, roave/better-reflection is used, which does a better
job and reduces false positives.

Since phpstan has been updated, the rules which have been copied
over from the vendor package had to be updated as well.

And since phpstan does find more errors now, a few rules had to
be disabled again.

Used commands:

    - composer require phpstan/phpstan:^0.12.37 --dev
    - composer require friendsoftypo3/phpstan-typo3:^0.4.0 --dev

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7