65010[WIP][FEATURE] Add RTE to Form Framework editor
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 6
- Feature #84849Allow links and some HTML tags in label, description, static text, validators, and emailBody
- Feature #90243Add prefix/suffix message to EmailToSender | EmailToReceiver
- Feature #84532Allow HTML inside the form element "static text"
- Feature #86949Allow HTML tags in Yaml configuration
- Feature #87199Allow RTE for Email finisher mail text
- Feature #87151RTE for confirmation finisher message
Files 69
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-84849-AddRteToForms.rstnew+49 −0
- typo3/sysext/form/Classes/Controller/AbstractBackendController.php+16 −20
- typo3/sysext/form/Classes/Controller/FormEditorController.php+101 −2
- typo3/sysext/form/Classes/Controller/FormManagerController.php+1 −1
- typo3/sysext/form/Classes/Controller/RteBrowseLinksController.phpnew+49 −0
- typo3/sysext/form/Classes/Domain/Finishers/EmailFinisher.php+77 −3
- typo3/sysext/form/Classes/Mvc/Property/TypeConverter/FormDefinitionArrayConverter.php+0 −1
- typo3/sysext/form/Classes/ViewHelpers/PlaintextViewHelper.phpnew+130 −0
- typo3/sysext/form/Configuration/Backend/Routes.phpnew+12 −0
- typo3/sysext/form/Configuration/RTE/Form.yamlnew+53 −0
- typo3/sysext/form/Configuration/TypoScript/setup.typoscript+17 −0
- typo3/sysext/form/Configuration/Yaml/Finishers/Confirmation.yaml+2 −0
- typo3/sysext/form/Configuration/Yaml/Finishers/EmailToReceiver.yaml+7 −0
- typo3/sysext/form/Configuration/Yaml/Finishers/EmailToSender.yaml+7 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/AdvancedPassword.yaml+34 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/Checkbox.yaml+10 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/Date.yaml+34 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/DatePicker.yaml+10 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/Email.yaml+38 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/Fieldset.yaml+3 −1
Show 49 more files
- typo3/sysext/form/Configuration/Yaml/FormElements/FileUpload.yaml+11 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/Form.yaml+62 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/GridRow.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Hidden.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Honeypot.yaml+24 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/ImageUpload.yaml+10 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiCheckbox.yaml+12 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/MultiSelect.yaml+12 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/Number.yaml+39 −4
- typo3/sysext/form/Configuration/Yaml/FormElements/Page.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Password.yaml+34 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/RadioButton.yaml+10 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/Rte.yamlnew+69 −0
- typo3/sysext/form/Configuration/Yaml/FormElements/SingleSelect.yaml+10 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/StaticText.yaml+16 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/SummaryPage.yaml+3 −1
- typo3/sysext/form/Configuration/Yaml/FormElements/Telephone.yaml+34 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/Text.yaml+26 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/Textarea.yaml+34 −2
- typo3/sysext/form/Configuration/Yaml/FormElements/Url.yaml+26 −2
- typo3/sysext/form/Configuration/Yaml/FormSetup.yaml+3 −0
- typo3/sysext/form/Configuration/JavaScriptModules.php+7 −1
- typo3/sysext/form/Configuration/Services.yaml+4 −0
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/RteTextEditor.htmlnew+18 −0
- typo3/sysext/form/Resources/Private/Backend/Partials/FormEditor/Inspector/ValidationErrorMessageEditor.html+1 −1
- typo3/sysext/form/Resources/Private/Backend/Templates/FormEditor/Yaml/NewForms/SimpleContactForm.yaml+1 −0
- typo3/sysext/form/Resources/Private/Frontend/Partials/SummaryPage.html+3 −3
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/All/Html.htmlnew+46 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/All/Plaintext.htmlnew+19 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.html+3 −41
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Default.txt+6 −11
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Html.htmlnew+14 −0
- typo3/sysext/form/Resources/Private/Frontend/Templates/Finishers/Email/Plaintext.htmlnew+11 −0
- typo3/sysext/form/Resources/Private/Language/Database.xlf+20 −0
- typo3/sysext/form/Resources/Public/Css/rte.cssnew+13 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js+189 −17
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/stage-component.js+5 −3
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/tree-component.js+4 −1
- typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/view-model.js+4 −3
- typo3/sysext/form/Resources/Public/JavaScript/backend/plugins/elementselector/icons/elementselector.svgnew+1 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/plugins/elementselector/lang/en.jsnew+1 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/plugins/elementselector/plugin.jsnew+101 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/plugins/elementselector/styles.cssnew+25 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/plugins/popout/icons/popout.svgnew+1 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/plugins/popout/lang/en.jsnew+1 −0
- typo3/sysext/form/Resources/Public/JavaScript/backend/plugins/popout/plugin.jsnew+95 −0
- typo3/sysext/form/Tests/Unit/Controller/AbstractBackendControllerTest.php+8 −2
- typo3/sysext/form/Tests/Unit/Mvc/Property/TypeConverter/FormDefinitionArrayConverterTest.php+7 −2
- typo3/sysext/form/ext_localconf.php+4 −0
Review log 4682
Show 2857 earlier messages
-
Gabe Troyan uploaded patch set 1 07/10/20, 15:39
-
TYPO3com voted on patch set 1 V -1 07/10/20, 15:39 Completed build in 21s on Fri, 10 Jul, 03:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4062
-
Stephan Großberndt commented on patch set 1 08/04/20, 14:56
You can find the reason for the failure in https://bamboo.typo3.com/browse/CORE-GTC-CGLCHECK-4062/log - the PHP code does not adhere to the CGL: 10-Jul-2020 15:39:33 cglFixMyCommit.sh: dryrun mode 10-Jul-2020 15:39:33 cglFixMyCommit.sh: Searching for php files in latest git commit ... 10-Jul-2020 15:39:33 Loaded config default from "Build/.php_cs". 10-Jul-2020 15:39:34 ...FFFFF...FF.F. 10-Jul-2020 15:39:34 Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error Use cglFixMyCommit.sh to fix this: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CglFixMyCommit.html -
Gabe Troyan uploaded patch set 2 08/04/20, 15:36
-
TYPO3com voted on patch set 2 V -1 08/04/20, 15:48 Completed build in 11m 37s on Tue, 4 Aug, 03:48 PM Test Summary: 36 of 73441 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4403
-
Gabe Troyan uploaded patch set 3 08/05/20, 17:20
-
TYPO3com voted on patch set 3 V -1 08/05/20, 17:21 Completed build in 26s on Wed, 5 Aug, 05:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4430
-
Gabe Troyan uploaded patch set 4 08/05/20, 17:32
-
TYPO3com voted on patch set 4 V -1 08/05/20, 17:44 Completed build in 11m 18s on Wed, 5 Aug, 05:44 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4431
-
Gabe Troyan uploaded patch set 5 08/05/20, 21:40
-
TYPO3com voted on patch set 5 V +1 08/05/20, 21:53 Completed build in 12m 47s on Wed, 5 Aug, 09:53 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4432
-
Gabe Troyan uploaded patch set 6 11/16/20, 22:20
-
TYPO3com voted on patch set 6 V -1 11/16/20, 22:32 Completed build in 11m 34s on Mon, 16 Nov, 10:32 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7368
-
Gabe Troyan uploaded patch set 7 11/16/20, 22:44
-
Gabe Troyan uploaded patch set 8 11/16/20, 22:54
-
TYPO3com voted on patch set 7 V -1 11/16/20, 22:58 Completed build in 13m 36s on Mon, 16 Nov, 10:58 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7369
-
TYPO3com voted on patch set 8 V +1 11/16/20, 23:07 Completed build in 13m 08s on Mon, 16 Nov, 11:07 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7370
-
Gabe Troyan uploaded patch set 9 03/09/21, 18:01
-
TYPO3com voted on patch set 9 V +1 03/09/21, 18:08 Completed build in 07m 25s on Tue, 9 Mar, 06:08 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9986
-
core-ci voted on patch set 9 V +1 03/09/21, 18:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1341
-
Gabe Troyan uploaded patch set 10 08/13/21, 15:06
-
core-ci voted on patch set 10 V -1 08/13/21, 15:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14988
-
Gabe Troyan rebased onto patch set 11 08/13/21, 15:30
-
Gabe Troyan rebased onto patch set 12 08/13/21, 15:40
-
core-ci voted on patch set 11 V -1 08/13/21, 15:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14994
-
core-ci voted on patch set 12 V -1 08/13/21, 15:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14995
-
core-ci commented on patch set 11 08/13/21, 16:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14994
-
Gabe Troyan uploaded patch set 13 08/13/21, 16:28
-
core-ci voted on patch set 13 V -1 08/13/21, 16:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14999
-
Gabe Troyan uploaded patch set 14 08/13/21, 16:36
-
core-ci voted on patch set 14 V -1 08/13/21, 16:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15000
-
Gabe Troyan uploaded patch set 15 08/13/21, 17:30
-
core-ci voted on patch set 15 V +1 08/13/21, 17:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15009
-
Gabe Troyan uploaded patch set 16 08/30/21, 14:31
-
core-ci voted on patch set 16 V -1 08/30/21, 14:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15869
-
Gabe Troyan uploaded patch set 17 08/30/21, 16:58
-
core-ci voted on patch set 17 V +1 08/30/21, 17:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15886
-
Gabe Troyan uploaded patch set 18 09/01/21, 19:49
-
core-ci voted on patch set 18 V -1 09/01/21, 20:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16034
-
Gabe Troyan uploaded patch set 19 09/01/21, 20:30
-
core-ci voted on patch set 19 V -1 09/01/21, 20:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16038
-
Gabe Troyan uploaded patch set 20 09/02/21, 14:14
-
core-ci voted on patch set 20 V +1 09/02/21, 14:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16087
-
Gabe Troyan uploaded patch set 21 09/02/21, 19:14
-
core-ci voted on patch set 21 V +1 09/02/21, 19:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16124
-
Nikita Hovratov uploaded patch set 22 09/03/21, 14:15
-
core-ci voted on patch set 22 V -1 09/03/21, 14:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16191
-
Gabe Troyan uploaded patch set 23 09/03/21, 16:39
-
core-ci voted on patch set 23 V +1 09/03/21, 16:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16206
-
Gabe Troyan uploaded patch set 24 09/03/21, 17:02
-
core-ci voted on patch set 24 V +1 09/03/21, 17:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16207
-
Gabe Troyan uploaded patch set 25 09/03/21, 21:14
-
core-ci voted on patch set 25 V +1 09/03/21, 21:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16217
-
Gabe Troyan uploaded patch set 26 11/22/21, 16:37
-
core-ci voted on patch set 26 V -1 11/22/21, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19649
-
Gabe Troyan uploaded patch set 27 11/22/21, 18:39
-
core-ci voted on patch set 27 V +1 11/22/21, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19651
-
Benni Mack wrote 11/29/21, 10:20
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 28 11/29/21, 14:10
-
core-ci voted on patch set 28 V +1 11/29/21, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20112
-
Gabe Troyan uploaded patch set 29 01/25/22, 16:35
-
core-ci voted on patch set 29 V -1 01/25/22, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22536
-
Gabe Troyan uploaded patch set 30 01/25/22, 16:43
-
core-ci voted on patch set 30 V -1 01/25/22, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22538
-
Benjamin Franzke commented on patch set 30 01/25/22, 19:03
InspectorComponent.js:24ckeditor is not available as ES6 module, but it should be loadable via CKEditorLoader. See https://review.typo3.org/c/Packages/TYPO3.CMS/+/72733/2/Build/Sources/TypeScript/rte_ckeditor/Resources/Public/TypeScript/CKEditorLoader.ts -
Benni Mack commented on patch set 30 01/25/22, 19:04
Hi Gabe, I already told this to Ralf, but maybe we could get this one in first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72705 which takes care of the processing and HTML handling in general, and then think about the RTE logic. The RTE is a bit of a pain (due to various reasons) to get into EXT:form, and we might consider upgrading to CKEditor5 as well, as CKEditor4 will reach End of life in 2023. -
Benjamin Franzke uploaded patch set 31 01/26/22, 07:47
-
Benjamin Franzke commented on patch set 31 01/26/22, 07:48
InspectorComponent.js:24ReplyDone -
core-ci voted on patch set 31 V +1 01/26/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22553
-
Gabe Troyan commented on patch set 31 01/27/22, 16:36
InspectorComponent.js:24ReplyResults in `Uncaught (in promise) TypeError: Failed to resolve module specifier "TYPO3/CMS/RteCkeditor/CKEditorLoader.js". Relative references must start with either "/", "./", or "../` -
Benjamin Franzke commented on patch set 31 01/28/22, 09:07
InspectorComponent.js:24ReplyYou mean with patchset 31? You need to clear all caches in order for the updated importmap configuration to be used (rte-ckeditor importmap need to be loaded). …otherwise this update doesn't take effect: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65010/31/typo3/sysext/form/Configuration/JavaScriptModules.php#7 -
Gabe Troyan commented on patch set 31 01/31/22, 22:35
InspectorComponent.js:24Reply UnresolvedYes, I've cleared all caches but I still can't load a form. Any other suggestions? -
Stephan Großberndt wrote 02/01/22, 11:01
Removed cc Stephan Großberndt. -
Benjamin Franzke uploaded patch set 32 02/19/22, 21:01
-
core-ci voted on patch set 32 V +1 02/19/22, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23911
-
Gabe Troyan uploaded patch set 33 02/24/22, 19:49
-
core-ci voted on patch set 33 V +1 02/24/22, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24228
-
Gabe Troyan uploaded patch set 34 02/24/22, 20:43
-
core-ci voted on patch set 34 V +1 02/24/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24234
-
Oliver Hader commented on patch set 34 06/30/22, 09:12
In general, we probably should have different sanitizers - one for rendering HTML in a browser, and another one for sending out emails. -
Christian Kuhn commented on patch set 34 11/27/24, 18:21
hey. this patch completely stalled for a long time already. i hope its ok to abandon the patch for now for the sake of a more clean review system. if work on this is picked up again, it can be resurrected of course. -
Christian Kuhn abandoned the change 11/27/24, 18:21