Review main Abandoned

65010[WIP][FEATURE] Add RTE to Form Framework editor

Gabe Troyan CR 0 V 0 Expert +1706 −158 updated 11/27/24, 18:21

Commit message

Allow editing some fields with a rich text editor rather than a standard
textbox or textarea. Allow HTML to be saved in YAML files. Includes and
extends https://review.typo3.org/c/Packages/TYPO3.CMS/+/56764 by Ralf
Zimmerman.

Use CKEditor for editing:

* Field labels
* Field descriptions
* Validator custom error messages
* Static Text
* Email finisher body text
* Confirmation finisher message

Make CKEditor plugins for form element selector and popping out the
editor. Mimic current behaviour of the Formelement Selection Button
using a CKEditor combobox.

Make email body field for Email Finishers; Allow editing the body of
email with an RTE rather than adjusting fluid templates. Move old email
fluid templates to "All" folder; use those templates when substituting
"{form_all}". Use "{form_all}" as default email body.

Review

  • Code review CR 0
  • Verified V 0

Issues 6

Files 69

Show 49 more files

Review log 4682

Show 2857 earlier messages
  1. Gabe Troyan uploaded patch set 1 07/10/20, 15:39

  2. TYPO3com voted on patch set 1 V -1 07/10/20, 15:39 Completed build in 21s on Fri, 10 Jul, 03:39 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4062

  3. Stephan Großberndt commented on patch set 1 08/04/20, 14:56

    You can find the reason for the failure in https://bamboo.typo3.com/browse/CORE-GTC-CGLCHECK-4062/log - the PHP code does not adhere to the CGL: 10-Jul-2020 15:39:33 cglFixMyCommit.sh: dryrun mode 10-Jul-2020 15:39:33 cglFixMyCommit.sh: Searching for php files in latest git commit ... 10-Jul-2020 15:39:33 Loaded config default from "Build/.php_cs". 10-Jul-2020 15:39:34 ...FFFFF...FF.F. 10-Jul-2020 15:39:34 Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error Use cglFixMyCommit.sh to fix this: https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/Appendix/CglFixMyCommit.html
  4. Gabe Troyan uploaded patch set 2 08/04/20, 15:36

  5. TYPO3com voted on patch set 2 V -1 08/04/20, 15:48 Completed build in 11m 37s on Tue, 4 Aug, 03:48 PM Test Summary: 36 of 73441 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4403

  6. Gabe Troyan uploaded patch set 3 08/05/20, 17:20

  7. TYPO3com voted on patch set 3 V -1 08/05/20, 17:21 Completed build in 26s on Wed, 5 Aug, 05:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4430

  8. Gabe Troyan uploaded patch set 4 08/05/20, 17:32

  9. TYPO3com voted on patch set 4 V -1 08/05/20, 17:44 Completed build in 11m 18s on Wed, 5 Aug, 05:44 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4431

  10. Gabe Troyan uploaded patch set 5 08/05/20, 21:40

  11. TYPO3com voted on patch set 5 V +1 08/05/20, 21:53 Completed build in 12m 47s on Wed, 5 Aug, 09:53 PM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4432

  12. Gabe Troyan uploaded patch set 6 11/16/20, 22:20

  13. TYPO3com voted on patch set 6 V -1 11/16/20, 22:32 Completed build in 11m 34s on Mon, 16 Nov, 10:32 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7368

  14. Gabe Troyan uploaded patch set 7 11/16/20, 22:44

  15. Gabe Troyan uploaded patch set 8 11/16/20, 22:54

  16. TYPO3com voted on patch set 7 V -1 11/16/20, 22:58 Completed build in 13m 36s on Mon, 16 Nov, 10:58 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7369

  17. TYPO3com voted on patch set 8 V +1 11/16/20, 23:07 Completed build in 13m 08s on Mon, 16 Nov, 11:07 PM Test Summary: 73689 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7370

  18. Gabe Troyan uploaded patch set 9 03/09/21, 18:01

  19. TYPO3com voted on patch set 9 V +1 03/09/21, 18:08 Completed build in 07m 25s on Tue, 9 Mar, 06:08 PM Test Summary: 32680 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-9986

  20. core-ci voted on patch set 9 V +1 03/09/21, 18:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1341

  21. Gabe Troyan uploaded patch set 10 08/13/21, 15:06

  22. core-ci voted on patch set 10 V -1 08/13/21, 15:27 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14988

  23. Gabe Troyan rebased onto patch set 11 08/13/21, 15:30

  24. Gabe Troyan rebased onto patch set 12 08/13/21, 15:40

  25. core-ci voted on patch set 11 V -1 08/13/21, 15:46 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14994

  26. core-ci voted on patch set 12 V -1 08/13/21, 15:58 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14995

  27. core-ci commented on patch set 11 08/13/21, 16:24 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14994

  28. Gabe Troyan uploaded patch set 13 08/13/21, 16:28

  29. core-ci voted on patch set 13 V -1 08/13/21, 16:31 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/14999

  30. Gabe Troyan uploaded patch set 14 08/13/21, 16:36

  31. core-ci voted on patch set 14 V -1 08/13/21, 16:55 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15000

  32. Gabe Troyan uploaded patch set 15 08/13/21, 17:30

  33. core-ci voted on patch set 15 V +1 08/13/21, 17:43 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15009

  34. Gabe Troyan uploaded patch set 16 08/30/21, 14:31

  35. core-ci voted on patch set 16 V -1 08/30/21, 14:53 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15869

  36. Gabe Troyan uploaded patch set 17 08/30/21, 16:58

  37. core-ci voted on patch set 17 V +1 08/30/21, 17:19 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/15886

  38. Gabe Troyan uploaded patch set 18 09/01/21, 19:49

  39. core-ci voted on patch set 18 V -1 09/01/21, 20:01 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16034

  40. Gabe Troyan uploaded patch set 19 09/01/21, 20:30

  41. core-ci voted on patch set 19 V -1 09/01/21, 20:35 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16038

  42. Gabe Troyan uploaded patch set 20 09/02/21, 14:14

  43. core-ci voted on patch set 20 V +1 09/02/21, 14:34 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16087

  44. Gabe Troyan uploaded patch set 21 09/02/21, 19:14

  45. core-ci voted on patch set 21 V +1 09/02/21, 19:31 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16124

  46. Nikita Hovratov uploaded patch set 22 09/03/21, 14:15

  47. core-ci voted on patch set 22 V -1 09/03/21, 14:36 Core CI is not happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16191

  48. Gabe Troyan uploaded patch set 23 09/03/21, 16:39

  49. core-ci voted on patch set 23 V +1 09/03/21, 16:55 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16206

  50. Gabe Troyan uploaded patch set 24 09/03/21, 17:02

  51. core-ci voted on patch set 24 V +1 09/03/21, 17:16 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16207

  52. Gabe Troyan uploaded patch set 25 09/03/21, 21:14

  53. core-ci voted on patch set 25 V +1 09/03/21, 21:29 Core CI is happy: https://gitlab.typo3.org/typo3/CI/cms/-/pipelines/16217

  54. Gabe Troyan uploaded patch set 26 11/22/21, 16:37

  55. core-ci voted on patch set 26 V -1 11/22/21, 16:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19649

  56. Gabe Troyan uploaded patch set 27 11/22/21, 18:39

  57. core-ci voted on patch set 27 V +1 11/22/21, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19651

  1. Benni Mack wrote 11/29/21, 10:20

    Change destination moved from master to main
  2. Benni Mack updated the commit message in patch set 28 11/29/21, 14:10

  3. core-ci voted on patch set 28 V +1 11/29/21, 18:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20112

  4. Gabe Troyan uploaded patch set 29 01/25/22, 16:35

  5. core-ci voted on patch set 29 V -1 01/25/22, 16:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22536

  6. Gabe Troyan uploaded patch set 30 01/25/22, 16:43

  7. core-ci voted on patch set 30 V -1 01/25/22, 16:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22538

  8. Benjamin Franzke commented on patch set 30 01/25/22, 19:03

    InspectorComponent.js:24

  9. Benni Mack commented on patch set 30 01/25/22, 19:04

    Hi Gabe, I already told this to Ralf, but maybe we could get this one in first: https://review.typo3.org/c/Packages/TYPO3.CMS/+/72705 which takes care of the processing and HTML handling in general, and then think about the RTE logic. The RTE is a bit of a pain (due to various reasons) to get into EXT:form, and we might consider upgrading to CKEditor5 as well, as CKEditor4 will reach End of life in 2023.
  10. Benjamin Franzke uploaded patch set 31 01/26/22, 07:47

  11. Benjamin Franzke commented on patch set 31 01/26/22, 07:48

    InspectorComponent.js:24 Reply

    Done
  12. core-ci voted on patch set 31 V +1 01/26/22, 07:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22553

  13. Gabe Troyan commented on patch set 31 01/27/22, 16:36

    InspectorComponent.js:24 Reply

    Results in `Uncaught (in promise) TypeError: Failed to resolve module specifier "TYPO3/CMS/RteCkeditor/CKEditorLoader.js". Relative references must start with either "/", "./", or "../`
  14. Benjamin Franzke commented on patch set 31 01/28/22, 09:07

    InspectorComponent.js:24 Reply

    You mean with patchset 31? You need to clear all caches in order for the updated importmap configuration to be used (rte-ckeditor importmap need to be loaded). …otherwise this update doesn't take effect: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65010/31/typo3/sysext/form/Configuration/JavaScriptModules.php#7
  15. Gabe Troyan commented on patch set 31 01/31/22, 22:35

    InspectorComponent.js:24 Reply Unresolved

    Yes, I've cleared all caches but I still can't load a form. Any other suggestions?
  16. Stephan Großberndt wrote 02/01/22, 11:01

    Removed cc Stephan Großberndt.
  17. Benjamin Franzke uploaded patch set 32 02/19/22, 21:01

  18. core-ci voted on patch set 32 V +1 02/19/22, 21:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23911

  19. Gabe Troyan uploaded patch set 33 02/24/22, 19:49

  20. core-ci voted on patch set 33 V +1 02/24/22, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24228

  21. Gabe Troyan uploaded patch set 34 02/24/22, 20:43

  22. core-ci voted on patch set 34 V +1 02/24/22, 20:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24234

  23. Oliver Hader commented on patch set 34 06/30/22, 09:12

    In general, we probably should have different sanitizers - one for rendering HTML in a browser, and another one for sending out emails.
  24. Christian Kuhn commented on patch set 34 11/27/24, 18:21

    hey. this patch completely stalled for a long time already. i hope its ok to abandon the patch for now for the sake of a more clean review system. if work on this is picked up again, it can be resurrected of course.
  25. Christian Kuhn abandoned the change 11/27/24, 18:21