Review 10.4 Abandoned

65033[FEATURE] Added Upgrade Wizard to Convert sys_domain to Site Config

Mohsin Khan CR 0 V 0 Hard +322 −0 updated 07/07/22, 20:47

Commit message

added Upgrade Wizard to convert sys_domain records to site configuration
in typo3conf/sites/ it helps save time during upgrade from TYPO3 V8
to TYPO3 V9 or TYPO3 V10, helps save time when you have 100's of
domain roots in your TYPO3 project.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1520

  1. Mohsin Khan uploaded patch set 1 07/13/20, 09:22

  2. TYPO3com voted on patch set 1 V +1 07/13/20, 09:35 Completed build in 12m 26s on Mon, 13 Jul, 09:35 AM Test Summary: 73886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-79

  3. Mohsin Khan uploaded patch set 2 07/15/20, 12:25

  4. TYPO3com voted on patch set 2 V +1 07/15/20, 12:36 Completed build in 11m 19s on Wed, 15 Jul, 12:36 PM Test Summary: 73886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-84

  5. Mohsin Khan rebased onto patch set 3 07/27/20, 10:33

  6. TYPO3com voted on patch set 3 V +1 07/27/20, 10:45 Completed build in 11m 52s on Mon, 27 Jul, 10:45 AM Test Summary: 73989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-119

  7. Jörg Bösche commented on patch set 3 CR -1 08/21/20, 07:45

    SysDomainToSiteConfiguration.php:27 Unresolved

    Please add a punctuation mark at the end of the sentence.

    SysDomainToSiteConfiguration.php:145 Unresolved

    The check is not necessary, because an empty array won't iterated (foreach).

    SysDomainToSiteConfiguration.php:194 Unresolved

    Why is the method visible for all? (visibilty: public) IMO the method visibility can be private.

    SysDomainToSiteConfiguration.php:207 Unresolved

    Add new line between the comment and variable.

    SysDomainToSiteConfiguration.php:276 Unresolved

    Streamline your return statements. In some methods there is a new line before the return statement and sometimes not.

    SysDomainToSiteConfiguration.php:285 Unresolved

    Same as above. Why is the method public?

    SysDomainToSiteConfiguration.php:299 Unresolved

    Is there any need to use "setFirstResult"? There is no pagination (offset), so it is sufficient if you specify setMaxResults.

    SysDomainToSiteConfiguration.php:303 Unresolved

    It is possible to use the elvis operator or cast the variable as (int). return $pageUid ?: 0; or return (int)$pageUid

    SysDomainToSiteConfiguration.php:307 Unresolved

    Uppercase first char. -> "Gets domain".

    SysDomainToSiteConfiguration.php:313 Unresolved

    Same as above. Why is the method public?
  8. Simon Gilli commented on patch set 3 CR -1 08/22/20, 10:06

    Unresolved

    We do not back port features, use master here
  9. Jörg Bösche updated the commit message in patch set 4 08/25/20, 06:31

  10. TYPO3com voted on patch set 4 V +1 08/25/20, 06:46 Completed build in 14m 28s on Tue, 25 Aug, 06:46 AM Test Summary: 74034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-264

  11. Simon Gilli commented on patch set 4 CR -1 08/25/20, 18:32

    @jörg changing the releases line is not enough, the patch needs also a rebase to master
  12. Tobi Kretschmann rebased onto patch set 5 08/26/20, 07:58

  13. TYPO3com voted on patch set 5 V +1 08/26/20, 08:10 Completed build in 12m 20s on Wed, 26 Aug, 08:10 AM Test Summary: 74043 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-276

  14. Jörg Bösche commented on patch set 5 08/26/20, 08:17

    > Patch Set 4: Code-Review-1 > > @jörg changing the releases line is not enough, the patch needs also a rebase to master Applied the patch to master and resolved the conflicts in ext_localconf.php. The master can be found here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65459 What is happening to this issue? Can someone abandon?
  15. Simon Gilli commented on patch set 5 CR -1 10/10/20, 07:57

    Dublicate, see comment of Jörg Bösche above
  16. Daniel Goerz abandoned the change 05/04/21, 20:32

    as dupe
  17. Mohsin Khan commented on patch set 5 05/05/21, 06:20

    Hello, Actually i am new to contribution in TYPO3. i would like to know that why its abounded?
  18. Mohsin Khan restored the change 06/22/22, 20:34

  19. Stefan Bürk commented on patch set 5 07/07/22, 20:47

    Reply

    Hi, the reason was given in the forge ticket. See: https://forge.typo3.org/issues/91790#note-9 ``` The patch was pending for a long time without anyone picking up. We abandoned it in gerrit for now and will probably not implement that for v10 or v11 anymore. ``` However, the implementation is quite naive and not generic enough. If you still need this during an upgrade, implement it as custom update wizard in your sitepackage or a custom extension with your current needs, if you really have that much "domains" etc. From a quick look, there are quite some constellations not proper regonized and handled.
  20. Stefan Bürk abandoned the change 07/07/22, 20:47