65033[FEATURE] Added Upgrade Wizard to Convert sys_domain to Site Config
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 2
Review log 1520
-
Mohsin Khan uploaded patch set 1 07/13/20, 09:22
-
TYPO3com voted on patch set 1 V +1 07/13/20, 09:35 Completed build in 12m 26s on Mon, 13 Jul, 09:35 AM Test Summary: 73886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-79
-
Mohsin Khan uploaded patch set 2 07/15/20, 12:25
-
TYPO3com voted on patch set 2 V +1 07/15/20, 12:36 Completed build in 11m 19s on Wed, 15 Jul, 12:36 PM Test Summary: 73886 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-84
-
Mohsin Khan rebased onto patch set 3 07/27/20, 10:33
-
TYPO3com voted on patch set 3 V +1 07/27/20, 10:45 Completed build in 11m 52s on Mon, 27 Jul, 10:45 AM Test Summary: 73989 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-119
-
Jörg Bösche commented on patch set 3 CR -1 08/21/20, 07:45
SysDomainToSiteConfiguration.php:145UnresolvedThe check is not necessary, because an empty array won't iterated (foreach).SysDomainToSiteConfiguration.php:194UnresolvedWhy is the method visible for all? (visibilty: public) IMO the method visibility can be private.SysDomainToSiteConfiguration.php:207UnresolvedAdd new line between the comment and variable.SysDomainToSiteConfiguration.php:276UnresolvedStreamline your return statements. In some methods there is a new line before the return statement and sometimes not.SysDomainToSiteConfiguration.php:285UnresolvedSame as above. Why is the method public?SysDomainToSiteConfiguration.php:299UnresolvedIs there any need to use "setFirstResult"? There is no pagination (offset), so it is sufficient if you specify setMaxResults.SysDomainToSiteConfiguration.php:303UnresolvedIt is possible to use the elvis operator or cast the variable as (int). return $pageUid ?: 0; or return (int)$pageUidSysDomainToSiteConfiguration.php:307UnresolvedUppercase first char. -> "Gets domain".SysDomainToSiteConfiguration.php:313UnresolvedSame as above. Why is the method public? -
Simon Gilli commented on patch set 3 CR -1 08/22/20, 10:06
Unresolved
We do not back port features, use master here -
Jörg Bösche updated the commit message in patch set 4 08/25/20, 06:31
-
TYPO3com voted on patch set 4 V +1 08/25/20, 06:46 Completed build in 14m 28s on Tue, 25 Aug, 06:46 AM Test Summary: 74034 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-264
-
Simon Gilli commented on patch set 4 CR -1 08/25/20, 18:32
@jörg changing the releases line is not enough, the patch needs also a rebase to master -
Tobi Kretschmann rebased onto patch set 5 08/26/20, 07:58
-
TYPO3com voted on patch set 5 V +1 08/26/20, 08:10 Completed build in 12m 20s on Wed, 26 Aug, 08:10 AM Test Summary: 74043 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-276
-
Jörg Bösche commented on patch set 5 08/26/20, 08:17
> Patch Set 4: Code-Review-1 > > @jörg changing the releases line is not enough, the patch needs also a rebase to master Applied the patch to master and resolved the conflicts in ext_localconf.php. The master can be found here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/65459 What is happening to this issue? Can someone abandon? -
Simon Gilli commented on patch set 5 CR -1 10/10/20, 07:57
Dublicate, see comment of Jörg Bösche above -
Daniel Goerz abandoned the change 05/04/21, 20:32
as dupe -
Mohsin Khan commented on patch set 5 05/05/21, 06:20
Hello, Actually i am new to contribution in TYPO3. i would like to know that why its abounded? -
Mohsin Khan restored the change 06/22/22, 20:34
-
Stefan Bürk commented on patch set 5 07/07/22, 20:47
Reply
Hi, the reason was given in the forge ticket. See: https://forge.typo3.org/issues/91790#note-9 ``` The patch was pending for a long time without anyone picking up. We abandoned it in gerrit for now and will probably not implement that for v10 or v11 anymore. ``` However, the implementation is quite naive and not generic enough. If you still need this during an upgrade, implement it as custom update wizard in your sitepackage or a custom extension with your current needs, if you really have that much "domains" etc. From a quick look, there are quite some constellations not proper regonized and handled. -
Stefan Bürk abandoned the change 07/07/22, 20:47
SysDomainToSiteConfiguration.php:27Unresolved