Review main Merged Breaking

65068[!!!][TASK] Store transOrigDiffSourceField as json string in db

Anja Leichsenring CR +2 V +2 Hard +266 −10 updated 07/31/20, 14:50

Commit message

The TCA ctrl transOrigDiffSourceField database field,
often called 'l18n_diffsource', stores information if
a default or source language record of a translated record
has been changed. This is used to hint editors with
"The record you translated from has been changed,
maybe an update of the translation is needed" in FormEngine.

The storage format of that field is a serialized PHP
string. This is no active, but a potential, general security
risk. To mitigate this, the storage format is changed to a
json string with the patch, including an install tool
database updater taking care of existing rows.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 11