Review main Abandoned

65088[BUGFIX] Apply quality constraint to processed images only once

Andreas Kienast CR 0 V 0 Easy +1 −4 updated 08/05/20, 11:25

Commit message

This patch changes the behavior of LocalCropScaleMaskHelper to not
shrink the image quality for its initial crop action anymore.

The issue was that the cropped variant of an image had a quality
constraint. The quality of that very image got worse in the further
processings as the same quality constraint was applied again.

The method `GraphicalFunctions::imageMagickConvert()` accepts the
arguments `$params` which is empty if the image processing configuration
doesn't include an `additionalParameters` element containing ImageMagick
parameters, which is nowhere defined in TYPO3 Core.

`GraphicalFunctions` defines a set of parameters applied by default, see
its constructor, and `$this->cmds`. One of those default parameters is
`-quality`.
If `GraphicalFunctions::imageMagickConvert` is called with an empty
`$params` attribute, these defaults get applied which lead to reducing
the image quality again.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1