Review main Merged

65134[BUGFIX] Allow routes without actual route variables for ExtbaseEnhancer

Oliver Hader CR +2 V +2 Easy +3 −1 updated 08/10/20, 10:54

Commit message

The route configuration shown below using `ExtbaseEnhancer` is currently
not evaluated anymore due to missing route variables in `routePath`. For
this particular case in `ExtbaseEnhancer` the controller-action pair is
implicitly defining variables.

MyPlugin:
  type: Extbase
  extension: ...
  plugin: ...
  routes:
    -
      routePath: '/action'
      _controller: 'MyController::action'

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1