Review main Merged

65136[BUGFIX] Discard only workspace records if deleting workspace

Christian Kuhn CR +2 V +2 Normal +199 −6 updated 07/31/20, 14:48

Commit message

Deleting a sys_workspace record currently fetches all live
records as to-delete candidates while only records of the
according workspace should be considered.
Luckily, a check at a later point prevents live records from
being deleted, though. The huge amount of records however stresses
DataHandler and database a lot.
This is a regression of the 'pid -1 gone' patch from a
broken database restriction.
The patch fixes the where clause and adds a functional test
to verify correct records are deleted.
Two todos in the test csv mark inconsistent details, those
could be handled with a different patch that should
review and increase test scenario coverage of version_WSID() first.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 4