Review 9.5 Merged

65152[BUGFIX] Properly return integer within resolvePreviewRecordId

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 07/31/20, 14:58

Commit message

As data is fetched from database, it might not be of proper types, e.g.
when using sqlite.
Therefore ensure returned value is of expected type.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Andreas Kienast commented on patch set 1 07/31/20, 14:37

    Cherry Picked from branch 10.4.
  2. Oliver Klee voted on patch set 1 CR +1 07/31/20, 14:45

  3. TYPO3com voted on patch set 1 V +1 07/31/20, 14:52 Completed build in 14m 05s on Fri, 31 Jul, 02:52 PM Test Summary: 75136 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-735

  4. Andreas Kienast voted on patch set 1 V +2 CR +2 07/31/20, 14:58

  5. Andreas Kienast merged patch set 2 07/31/20, 14:58