Review main Merged

65175[BUGFIX] Improve error message when deleting a page with disallowed tables

Benni Mack CR +2 V +2 Easy +8 −7 updated 08/04/20, 18:32

Commit message

When deleting a page with records an editor does not have access to,
the error message "Attempt to delete records from disallowed tables"
is shown which does not give a hint to the editor what tables are an issue.

This change improves the error message to show the tables
that are prohibited.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 08/04/20, 07:44

  2. TYPO3com voted on patch set 1 V +1 08/04/20, 07:56 Completed build in 11m 56s on Tue, 4 Aug, 07:56 AM Test Summary: 72956 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4388

  3. Oliver Klee commented on patch set 1 08/04/20, 09:58

    DataHandler.php:7885

    Should this be string[]|null (so we can be more specific)?
  4. Benni Mack commented on patch set 2 08/04/20, 10:32

    Published edit on patch set 1.
  5. Benni Mack commented on patch set 2 08/04/20, 10:33

    DataHandler.php:7885 Reply

    good point! Thanks for the hint!
  6. TYPO3com voted on patch set 2 V +1 08/04/20, 10:44 Completed build in 11m 26s on Tue, 4 Aug, 10:44 AM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4396

  7. Christian Kuhn voted on patch set 2 V +1 CR +1 08/04/20, 13:16

  8. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/04/20, 18:32

  9. Anja Leichsenring merged patch set 3 08/04/20, 18:32