Review main Merged Breaking

65184[!!!][TASK] FAL: Decouple logic of ResourceFactory into StorageRepository

Benni Mack CR +2 V +2 Expert +585 −448 updated 09/30/20, 14:22

Commit message

The "ResourceFactory" class was introduced as a "god class" to build
any File/Folder object (from a string, DB row or integer), but is also
there for building sys_file_storage (ResourceStorage) objects, so it is
mixing a lot of concerns (also driver setup).

However, all creation of ResourceStorage objects should be moved into
the StorageRepository (which already exists), thus reducing
the dependencies towards ResourceFactory.

This makes it much easier to not juggle with storage UIDs anymore
but actually work with storage objects throughout the internal FAL
API.

The StorageRepository is not extending from the AbstractRepository
anymore, which is breaking.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 27

Show 7 more files