Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.

Review main Work in progress Orphaned

65186[FEATURE] Add option for the video poster attribute

Kevin Ditscheid CR 0 V -1 Normal +180 −13 updated 03/25/25, 10:35

Commit message

This commit adds an option to include the poster attribute.
The value will be processed by LinkService to be able to use
TypoLink URNs.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 12
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/65186/12 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/86/65186/12 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Issues 1

Files 8

Review log 2738

Show 1013 earlier messages
  1. Kevin Ditscheid uploaded patch set 1 08/05/20, 11:09

  2. TYPO3com voted on patch set 1 V +1 08/05/20, 11:20 Completed build in 10m 43s on Wed, 5 Aug, 11:20 AM Test Summary: 72957 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4419

  3. Kevin Ditscheid commented on patch set 1 08/05/20, 12:30

    VideoTagRenderer.php:110

    Not sure if I need to do htmlspeciachars here or not
  4. Jörg Bösche uploaded patch set 2 09/01/20, 14:10

  5. TYPO3com voted on patch set 2 V -1 09/01/20, 14:21 Completed build in 11m 07s on Tue, 1 Sep, 02:21 PM Test Summary: 272 of 73673 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5109

  6. TYPO3com voted on patch set 2 V +1 09/02/20, 06:46 Completed build in 11m 00s on Wed, 2 Sep, 06:46 AM Test Summary: 73188 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5122

  7. Guido Schmechel commented on patch set 2 V -1 10/21/20, 17:11

    For me this is more a feature than a task. Therefore a RST/documentation would also be necessary. As editor i would also like to have the possibility to choose a poster on the video to maintain it editorially. Example: As reference to the video file. Advantage: Only image files can be unlocked here. Btw: poster could already be set via additionalAttributes. Just my two cents :-)
  8. Martin Kutschker commented on patch set 2 06/03/21, 08:25

    > For me this is more a feature than a task. Therefore a RST/documentation would also be necessary. Yes. > As editor i would also like to have the possibility to choose a poster on the video to maintain it editorially. Example: As reference to the video file. Also yes. Something along thh way of the pending #66214
  9. Martin Kutschker commented on patch set 2 06/03/21, 08:27

    Reply

    > Also yes. Something along thh way of the pending #66214 #92200 (# refers to Forge not Gerrit, sorry
  10. Oli Bartsch commented on patch set 2 06/07/21, 08:23

    VideoTagRenderer.php:110

    This should IMO also support FileInterface. So passing a File or a file reference directly.
  11. Benni Mack wrote 11/29/21, 10:06

    Change destination moved from master to main
  12. Benni Mack updated the commit message in patch set 3 11/29/21, 13:22

  13. Benni Mack commented on patch set 3 01/14/22, 16:18

    I think this should / could be labeled as feature
  1. Nikita Hovratov uploaded patch set 4 01/22/22, 21:59

  2. Nikita Hovratov commented on patch set 4 01/22/22, 22:01

    Reply

    Done
    Rebased and refactored the tests a bit. Also added possibility for providing FileInterfaces.

    VideoTagRenderer.php:110 Reply

    Done

    VideoTagRenderer.php:110 Reply

    Done
  3. core-ci voted on patch set 4 V -1 01/22/22, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22415

  4. Nikita Hovratov uploaded patch set 5 01/22/22, 22:30

  5. core-ci voted on patch set 5 V +1 01/22/22, 22:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/22417

  6. Jörg Bösche voted on patch set 5 CR +1 04/18/23, 07:28

  7. Benni Mack updated the commit message in patch set 6 CR +1 V +1 04/18/23, 14:16

  8. core-ci voted on patch set 6 V -1 04/18/23, 14:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/40879

  9. Benni Mack updated the commit message in patch set 7 V -1 05/03/23, 09:53

  10. Simon Schaufelberger uploaded patch set 8 08/21/23, 20:00

  11. core-ci voted on patch set 8 V -1 08/21/23, 20:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45654

  12. Simon Schaufelberger uploaded patch set 9 V -1 08/21/23, 20:26

  13. core-ci voted on patch set 9 V +1 08/21/23, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45656

  14. Benni Mack commented on patch set 9 09/05/23, 16:15

    sorry guys. as much as I want this feature. This is only half the story. And there were no reactions since a few years rather than rebasing - Masi's an Guido's comments are 100% legit and not taken care of: Summary: a) Nice to have this as option in the code, but how can an editor set a poster image? In sys_file_reference or in sys_file b) no RST as this is obvious a feature (which was only available in the old media handling without FAL) c) no progress on the actual change than rebasing. seeing c) if nothing changes I suggest to abandon this change in a few days / weeks.
  15. Guido Schmechel commented on patch set 9 09/16/23, 17:47

    Reply Unresolved

    I also find the feature useful and would like to push it. For me, however, a few things are still unclear here. 1) Do we need a separate poster attribute for the MediaViewHelper or is a reference to the additionalConfig sufficient? (This affects the documentation) I would plead for a new attribute. 2) Do we have to reimplement the old logic from https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/7.5/Feature-63395-Html5VideoPosterPreviewImage.html ? And if so: Does the file in the folder have more priority or the image at the reference? As mentioned: Where should the editor maintain the image? I would rather expect a possibility here at the reference. More flexibility. For example, for promo codes on images or similar. Definitely a difference to the VTT files.
  16. Benni Mack commented on patch set 9 09/18/23, 04:01

    Hey Guido, this is a POC extension I created for v10+ https://github.com/b13/poster-image
  17. Guido Schmechel uploaded patch set 10 V +1 09/19/23, 18:01

  18. core-ci voted on patch set 10 V -1 09/19/23, 18:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46817

  19. Guido Schmechel uploaded patch set 11 V -1 09/19/23, 19:04

  20. core-ci voted on patch set 11 V -1 09/19/23, 19:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46826

  21. Guido Schmechel uploaded patch set 12 V -1 09/19/23, 19:23

  22. core-ci voted on patch set 12 V -1 09/19/23, 19:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/46827

  23. Guido Schmechel commented on patch set 12 09/19/23, 19:52

    I have integrated the PoC for discussion. Still open: Does there need to be logic to read an image with the same names in the folder? This is how I would imagine the priority: 1. image with same name in folder 2. attribute given via fluid 3. property poster in the file And of course a CGL cleanup at the end + RST file at the end.
  24. Guido Schmechel commented on patch set 12 09/22/23, 21:02

    Reply Unresolved

    And a follow-up question: How can we display the posterImage again only for normal videos and not for online media? In the Text Track Patch (https://review.typo3.org/c/Packages/TYPO3.CMS/+/66214) I had added a condition that checks for mimetypes. Of course, this could be set up more generally Example: VideoCondition->isLocalMedia or VideoCondition->isOnlineMedia This condition could then also be used for the posterImage.
  25. Benni Mack marked it work in progress 03/25/25, 10:35