Review main Merged

65188[BUGFIX] Allow moving a workspace record after itself

Christian Kuhn CR +2 V +2 Hard +277 −11 updated 08/06/20, 09:08

Commit message

Another 'broken since ever' fix: Sorting a record in
workspaces by moving it 'after itself', the record vanishes
from the interface. While this action is kinda useless,
it can for instance accidently happen by an editor.

As with other move operations in workspaces, a move
placeholder and the versioned data record is created.
In case of inserting after itself, the move placeholder
state is not correctly updated - both pid and sorting
values end up with 0. The records then no longer belong
to the correct pid and are not 'seen' by workspaces.

The patch fixes this case by making sure the pid and sorting
determination of the move placeholder does not accidently
operate on itself as reference record. A series of functional
DataHandler tests nail the correct state for pages and
tt_content in non-workspace and workspace scenarios.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 14