Review main Merged

65214[BUGFIX] IRRE: Handle localizable records correctly

Andreas Kienast CR +2 V +2 Easy +4 −3 updated 08/25/20, 19:00

Commit message

Each node in an IRRE container now has a new `data-placeholder-record`
attribute to be able to identify such node w/out accessing CSS classes
used for styling purpose.

Nodes where `data-placeholder-record` has a truthy value are localizable
and are ignored now when the sorting is changed which solves an issue
where such records would have been moved into a different language.

In the same run the localization is fixed as it was tried to iterate an
object, which doesn't work. Alternatively, the object values are fetched
and iterated now.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3