Review main Merged

65230[BUGFIX] Skip processing of inline children which aren't workspace-aware

Christian Kuhn CR +2 V +2 Normal +121 −0 updated 08/10/20, 14:41

Commit message

When dealing with inline foreign field setups in workspaces
and having a child table not workspace aware, the DataHandler
still tries to create workspace copies of the not workspace
aware child.

In v9, it sets pid=-1 for those records, which succeeds if the
pid db field is signed. In this case a dead record of the
child is created. If the field is unsigned, the insertion fails
and an error message is created.

In v10 and master pid=-1 is gone and the real pid is set, the
record is created and becomes a 1:1 duplicate in live workspace.

The patch adds an according check to the DataHandler in
workspace context to skip not workspace aware children.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 7