Review main Merged

65234[BUGFIX] Fix ObjectAccess::isPropertyGettable for ArrayAccess objects

Alexander Schnitzler CR +2 V +2 Easy +36 −7 updated 09/17/20, 18:59

Commit message

While introducing symfony/property-access, method isPropertyGettable
of class ObjectAccess had been adjusted in a manner which made the
mixed usage of array access and regular property access impossible.

If an object implemented ArrayAccess and used regular properties,
all of those properties were reported inacessible/non-gettable which
is not true.

With this patch, regular properties and those defined magically
via ArrayAccess are detected correctly as gettable.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2