65240[TASK] Add basic test for ShowImageController (tx_cms_showpic)
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Alexander Schnitzler +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Alexander Schnitzler +1
- core-ci +1 CI
Issues 1
Files 1
Review log 2632
Show 57 earlier messages
-
Oliver Hader uploaded patch set 1 08/10/20, 13:28
-
TYPO3com voted on patch set 1 V +1 08/10/20, 13:40 Completed build in 12m 04s on Mon, 10 Aug, 01:40 PM Test Summary: 72977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4548
-
Benni Mack wrote 11/29/21, 09:58
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 2 11/29/21, 13:17
-
Oliver Hader uploaded patch set 3 05/15/23, 10:29
-
Oliver Hader commented on patch set 3 05/15/23, 10:29
This change is ready for review. -
core-ci voted on patch set 3 V -1 05/15/23, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41832
-
Oliver Hader uploaded patch set 4
V -105/15/23, 10:48 -
core-ci voted on patch set 4 V +1 05/15/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41833
-
Stefan Bürk commented on patch set 4 05/15/23, 12:01
Did not had a deep look, but one question raised directly in my mind. Instead of doing a mocks in a functional test, is there a reason a missed not providing the file in the test instance (fileadmin) + fal and executing a frontend subrequest to the eId handler ? Maybe I'm failing to get the point. -
Oliver Hader commented on patch set 4 05/15/23, 15:38
Reply
This change was lying around since August 2020, I just updated it and cannot really remember why it was based on mocks. So, I just can guess that is was related to the configuration overhead (storage, file, file properties and hashes, frontend site, page structure, and maybe TypoScript)... -
Stefan Bürk commented on patch set 4 05/15/23, 15:42
Reply
If it is okay for you, I would try to change that. Sadly, I'm full today, eventually one of the next to evenings. -
Oliver Hader commented on patch set 4 05/15/23, 15:53
Reply
Sure, that's totally fine for me! I'm think these tests were somehow related to CVE-2020-15086 (https://github.com/advisories/GHSA-4h44-w6fm-548g) -
Oliver Hader commented on patch set 4 05/15/23, 15:57
Reply
and for TYPO3 core: CVE-2020-15099 (https://github.com/advisories/GHSA-3x94-fv5h-5q2c) -
Oliver Hader commented on patch set 4 06/26/23, 08:49
Reply
How to continue with this change? -
Benni Mack commented on patch set 4 07/04/23, 10:37
Reply
Please continue here. -
Oliver Klee uploaded patch set 5
V +107/08/23, 08:13 -
Oliver Klee voted on patch set 5 V +1 07/08/23, 08:13
-
core-ci voted on patch set 5 V +1 07/08/23, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43935
-
Stefan Bürk commented on patch set 5 07/11/23, 08:18
Reply
I guess we can keep this simple for now and having the tests in that way was a good decision. Sorry for the interruption on here. -
Stefan Bürk voted on patch set 5 V +1 CR +1 07/11/23, 08:19
-
Alexander Schnitzler commented on patch set 5 07/11/23, 08:26
ShowImageControllerTest.php:95Are those expectations on the mocks part of the things you actually want to test? If not, I suggest dropping those and simply implement the desired mock behavior without implicit assertions. -
Oliver Klee commented on patch set 5 07/11/23, 09:05
ShowImageControllerTest.php:95ReplyDone -
Oliver Klee uploaded patch set 6
CR +1V +107/11/23, 09:05 -
Oliver Klee voted on patch set 6 V +1 07/11/23, 09:05
-
Oliver Klee uploaded patch set 7
V +107/11/23, 09:09 -
Oliver Klee voted on patch set 7 V +1 07/11/23, 09:09
-
core-ci voted on patch set 7 V +1 07/11/23, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44016
-
core-ci voted on patch set 6 V +1 07/11/23, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44015
-
Alexander Schnitzler voted on patch set 7 V +1 CR +1 07/11/23, 09:21
-
Benni Mack voted on patch set 7 V +2 CR +2 07/11/23, 09:30
-
Benni Mack merged patch set 8 07/11/23, 09:30