Review main Merged

65240[TASK] Add basic test for ShowImageController (tx_cms_showpic)

Oliver Hader CR +2 V +2 Normal +169 −0 updated 07/11/23, 09:30

Commit message

Adds a basic test case for simulating the behavior of the eID
script `tx_cms_showpic` in the frontend rendering process.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Alexander Schnitzler +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 2632

Show 57 earlier messages
  1. Oliver Hader uploaded patch set 1 08/10/20, 13:28

  2. TYPO3com voted on patch set 1 V +1 08/10/20, 13:40 Completed build in 12m 04s on Mon, 10 Aug, 01:40 PM Test Summary: 72977 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4548

  3. Benni Mack wrote 11/29/21, 09:58

    Change destination moved from master to main
  4. Benni Mack updated the commit message in patch set 2 11/29/21, 13:17

  5. Oliver Hader uploaded patch set 3 05/15/23, 10:29

  6. Oliver Hader commented on patch set 3 05/15/23, 10:29

    This change is ready for review.
  7. core-ci voted on patch set 3 V -1 05/15/23, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41832

  1. Oliver Hader uploaded patch set 4 V -1 05/15/23, 10:48

  2. core-ci voted on patch set 4 V +1 05/15/23, 10:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41833

  3. Stefan Bürk commented on patch set 4 05/15/23, 12:01

    Did not had a deep look, but one question raised directly in my mind. Instead of doing a mocks in a functional test, is there a reason a missed not providing the file in the test instance (fileadmin) + fal and executing a frontend subrequest to the eId handler ? Maybe I'm failing to get the point.
  4. Oliver Hader commented on patch set 4 05/15/23, 15:38

    Reply

    This change was lying around since August 2020, I just updated it and cannot really remember why it was based on mocks. So, I just can guess that is was related to the configuration overhead (storage, file, file properties and hashes, frontend site, page structure, and maybe TypoScript)...
  5. Stefan Bürk commented on patch set 4 05/15/23, 15:42

    Reply

    If it is okay for you, I would try to change that. Sadly, I'm full today, eventually one of the next to evenings.
  6. Oliver Hader commented on patch set 4 05/15/23, 15:53

    Reply

    Sure, that's totally fine for me! I'm think these tests were somehow related to CVE-2020-15086 (https://github.com/advisories/GHSA-4h44-w6fm-548g)
  7. Oliver Hader commented on patch set 4 05/15/23, 15:57

    Reply

    and for TYPO3 core: CVE-2020-15099 (https://github.com/advisories/GHSA-3x94-fv5h-5q2c)
  8. Oliver Hader commented on patch set 4 06/26/23, 08:49

    Reply

    How to continue with this change?
  9. Benni Mack commented on patch set 4 07/04/23, 10:37

    Reply

    Please continue here.
  10. Oliver Klee uploaded patch set 5 V +1 07/08/23, 08:13

  11. Oliver Klee voted on patch set 5 V +1 07/08/23, 08:13

  12. core-ci voted on patch set 5 V +1 07/08/23, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43935

  13. Stefan Bürk commented on patch set 5 07/11/23, 08:18

    Reply

    I guess we can keep this simple for now and having the tests in that way was a good decision. Sorry for the interruption on here.
  14. Stefan Bürk voted on patch set 5 V +1 CR +1 07/11/23, 08:19

  15. Alexander Schnitzler commented on patch set 5 07/11/23, 08:26

    ShowImageControllerTest.php:95

    Are those expectations on the mocks part of the things you actually want to test? If not, I suggest dropping those and simply implement the desired mock behavior without implicit assertions.
  16. Oliver Klee commented on patch set 5 07/11/23, 09:05

    ShowImageControllerTest.php:95 Reply

    Done
  17. Oliver Klee uploaded patch set 6 CR +1 V +1 07/11/23, 09:05

  18. Oliver Klee voted on patch set 6 V +1 07/11/23, 09:05

  19. Oliver Klee uploaded patch set 7 V +1 07/11/23, 09:09

  20. Oliver Klee voted on patch set 7 V +1 07/11/23, 09:09

  21. core-ci voted on patch set 7 V +1 07/11/23, 09:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44016

  22. core-ci voted on patch set 6 V +1 07/11/23, 09:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44015

  23. Alexander Schnitzler voted on patch set 7 V +1 CR +1 07/11/23, 09:21

  24. Benni Mack voted on patch set 7 V +2 CR +2 07/11/23, 09:30

  25. Benni Mack merged patch set 8 07/11/23, 09:30