65285[BUGFIX] Properly convert setting detectDomainRecords
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 912
-
Georg Ringer uploaded patch set 1 08/12/20, 06:34
-
Georg Ringer commented on patch set 1 08/12/20, 06:35
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 08/12/20, 06:35 Completed build in 25s on Wed, 12 Aug, 06:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4590
-
Benni Mack commented on patch set 1 08/13/20, 07:11
SearchController.php:1598Unresolvedunneeded whitespace lines, right? -
Benni Mack updated the commit message in patch set 2 08/13/20, 11:26
-
TYPO3com voted on patch set 2 V -1 08/13/20, 11:27 Completed build in 26s on Thu, 13 Aug, 11:27 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4615
-
Christian Kuhn uploaded patch set 3 08/18/20, 17:35
-
Christian Kuhn commented on patch set 3 CR +1 08/18/20, 17:36
looks good to me, but honestly, i did not test ... maybe this could go through as 'obvious'? -
TYPO3com voted on patch set 3 V +1 08/18/20, 17:47 Completed build in 11m 59s on Tue, 18 Aug, 05:47 PM Test Summary: 72998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4764
-
Christian Kuhn voted on patch set 3 V +1 08/21/20, 11:26
-
Andreas Kienast voted on patch set 3 V +2 CR +2 08/21/20, 15:48
-
Andreas Kienast merged patch set 4 08/21/20, 15:48