Review main Merged

65396[TASK] Replace string parsing in Message with unpack

Claus Due CR +2 V +2 Easy +20 −19 updated 02/25/21, 17:01

Commit message

Replaces an inefficient string parsing using strlen, for
and ord, to use unpack instead. Saves one call to strlen
per header, and potentially thousands of calls to ord
per request.

The same strategy is used in Message->filter, however,
this method does not appear to be used so the unpack
change is only applied in isValidHeaderValue.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2