Review main Merged

65404[TASK] Use named export of MessageUtility in Scheduler.ts

Benjamin Franzke CR +2 V +2 Easy +2 −2 updated 08/21/20, 14:30

Commit message

`import = require('…')` should only be used when
the required module exports via the respective `export =`
instruction.

As MessageUtility exports only one named export
(called `MessageUtility`), we should import
via ES6 named import syntax.

Note: Technically (in the generated source) this change
makes no difference, as the named export was available
as property of the AMD export-object, and therefore
`import = ` worked.

Therefore there are no changes to the generated files when executing:

  grunt build

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1