Review main Merged

6543[BUGFIX] Disambiguate labels in exclude fields list

Francois Suter CR +2 V +2 Easy +6 −3 updated 06/03/13, 20:49

Commit message

When defining access lists for be_groups, all exclude fields are
listed for selection, ordered alphabetically per table and field
label. It may happen that some fields have the same label within
the same table. This causes confusion.

This patch adds the field's name next to its label to avoid
confusion.

Review

  • Code review CR +2
    • Francois Suter +2
    • Georg Ringer +1
    • Philipp Gampe +1
  • Verified V +2
    • Francois Suter +2
    • Georg Ringer +1
    • Philipp Gampe +1

Files 1

Review log 5

  1. Francois Suter commented on patch set 1 V 0 11/05/11, 20:58

    by team member; Looks good to me, approved Thanks for the reviews!
  2. Georg Ringer commented on patch set 1 11/05/11, 20:58

    Verified; Looks good to me, but someone else must approve
  3. Philipp Gampe commented on patch set 1 11/05/11, 20:58

    Verified; Looks good to me, but someone else must approve Works for me.
  4. Mr. Jenkins commented on patch set 1 11/05/11, 20:58

  5. Francois Suter merged patch set 1 11/05/11, 20:58