Review main Merged

65440[TASK] Deprecate 3rd party usages of getTreeList() in QueryGenerator and QueryView

Christian Kuhn CR +2 V +2 Hard +197 −96 updated 08/25/20, 17:10

Commit message

The nearly identical methods getTreeList() of core classes
QueryGenerator and QueryView are standalone methods that do
not depend on further state of those classes.
Those classes mostly belong to the ext:lowlevel
DatabaseIntegrityController as their main jobs.
To allow further refactoring of them, the patch drops 3rd party
usages in ext:extbase and ext:workspaces, and protects the methods
in a backwards compatible way.
The new implementations are slightly more effective by skipping
string implode/explode operations.
The extbase change is accompanied by a new functional test to
drop two heavy mocking unit tests.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 9