Review main Merged

65451[BUGFIX] Properly set user to admin in setup module

Christian Kuhn CR +2 V +2 Easy +8 −3 updated 08/26/20, 12:48

Commit message

SetupModuleController serves as a backdoor so regular users without
permission to manipulate be_users records can still edit their profile.
For this to work, the access check needs to be bypassed for this
particular record by DataHandler.

The start() method of DataHandler prepares e.g. exclude fields to be checked.
With current code, incoming user is not yet set to admin, so exclude field
checking may fail, especially if 3rd party extensions manipulate this.
The patch hands a temporary user with activated admin flag to DataHandler,
so it can bypass the access check for profile editing.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1