Review main Merged

65461[TASK] DatabaseRecordList: Streamline limit handling

Daniel Windloff CR +2 V +2 Normal +33 −51 updated 08/28/20, 14:50

Commit message

The actual limit, used in the getTable(), depends on various
configurations, current view (default view, single table view)
and current action (view, search or csv export).

To get a better overview, the patch moves limit handling to the
getTable() method, so limit handling in start() and generateList()
can be removed. The properties itemsLimitPerTable
and itemsLimitSingleTable are removed as well.

The configured limit (excluding search and CSV export) is now
forced to be in a range from 5 to 10000.

For translated pages, the pages configuration is used to set the limit.

The limit is set by the following chain:
[default view with multiple tables; single table view]

- default value [20; 100]
- if page ts config is set [itemsLimitPerTable; itemsLimitSingleTable]
- if tca configuration is set [maxDBListItems; maxSingleDBListItems]
- a forced range from 5 to 10000
- if limit is set in the search
- no limit for a csv export

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1016

  1. Daniel Windloff uploaded patch set 1 08/26/20, 10:54

  2. TYPO3com voted on patch set 1 V +1 08/26/20, 11:05 Completed build in 10m 48s on Wed, 26 Aug, 11:05 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4974

  3. Daniel Windloff uploaded patch set 2 08/26/20, 11:25

  4. TYPO3com voted on patch set 2 V +1 08/26/20, 11:37 Completed build in 11m 11s on Wed, 26 Aug, 11:37 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4976

  5. Jörg Bösche commented on patch set 2 CR -1 08/26/20, 12:29

    DatabaseRecordList.php:731

    Add a new line before the comments. IMO, it optimizes readability
  6. Daniel Windloff uploaded patch set 3 08/26/20, 12:58

  7. Daniel Windloff commented on patch set 3 08/26/20, 12:59

    DatabaseRecordList.php:731 Reply

    Done
  8. Jörg Bösche voted on patch set 3 CR +1 08/26/20, 13:28

  9. TYPO3com voted on patch set 3 V -1 08/26/20, 13:49 Completed build in 46m 44s on Wed, 26 Aug, 01:49 PM Test Summary: 37 of 72763 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4980

  10. TYPO3com commented on patch set 3 08/26/20, 14:42 Completed build in 41m 28s on Wed, 26 Aug, 02:42 PM Test Summary: 18 of 72895 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4990

  11. TYPO3com voted on patch set 3 V +1 08/27/20, 09:52 Completed build in 16m 19s on Thu, 27 Aug, 09:52 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5003

  12. Christian Kuhn updated the commit message in patch set 4 08/27/20, 12:30

  13. Christian Kuhn voted on patch set 4 V +1 CR +1 08/27/20, 12:31

  14. TYPO3com voted on patch set 4 V +1 08/27/20, 12:42 Completed build in 11m 56s on Thu, 27 Aug, 12:42 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5010

  15. Andreas Kienast voted on patch set 4 V +2 CR +2 08/28/20, 14:50

  16. Andreas Kienast merged patch set 5 08/28/20, 14:50