Review main Merged

65470[TASK] DatabaseRecordList: Drop property `fixedL`

Daniel Windloff CR +2 V +2 Easy +1 −12 updated 08/28/20, 13:49

Commit message

The property `fixedL` was only used once (see `ElementBrowserRecordList`,
`BackendUtility::getRecordTitlePrep`). The removal of the second
parameter `fixedL` in `getRecordTitlePrep` hasn't changed the behaviour,
as the backend user's UC `titleLen` is used as default constraint anyway.

Therefore, the property `fixedL` has been removed.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Daniel Windloff uploaded patch set 1 08/27/20, 08:46

  2. Oliver Klee voted on patch set 1 CR +1 08/27/20, 09:08

  3. TYPO3com voted on patch set 1 V +1 08/27/20, 09:12 Completed build in 15m 10s on Thu, 27 Aug, 09:12 AM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-4999

  4. Jörg Bösche voted on patch set 1 CR +1 08/27/20, 10:41

  5. Christian Kuhn voted on patch set 1 V +1 CR +1 08/27/20, 12:23

  6. Björn Jacob voted on patch set 1 CR +1 08/28/20, 04:50

  7. Andreas Kienast uploaded patch set 2 08/28/20, 13:19

  8. Andreas Kienast voted on patch set 2 V +1 CR +1 08/28/20, 13:19

  9. Christian Kuhn voted on patch set 2 V +1 CR +1 08/28/20, 13:27

  10. TYPO3com voted on patch set 2 V -1 08/28/20, 13:38 Completed build in 13m 50s on Fri, 28 Aug, 01:38 PM Test Summary: 1 of 73577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5035

  11. TYPO3com voted on patch set 2 V +1 08/28/20, 13:47 Completed build in 37m 05s on Fri, 28 Aug, 01:47 PM Test Summary: 73090 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5035

  12. Andreas Kienast voted on patch set 2 V +2 CR +2 08/28/20, 13:49

  13. Andreas Kienast merged patch set 3 08/28/20, 13:49