Review main Merged

65494[BUGFIX] Do not show record history workspace entries in live

Christian Kuhn CR +2 V +2 Normal +49 −27 updated 03/14/21, 18:10

Commit message

Record history tends to show changes of content elements
that have been done in a workspace in live. This is
misleading.
The patch changes the queries a bit to fetch correct
records only and adapts the workspace view a bit to
be more meaningful.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • Benni Mack +1
    • TYPO3com +1 CI
    • core-ci +1 CI

Issues 1

Files 4

Review log 1723

  1. Christian Kuhn uploaded patch set 1 08/27/20, 12:20

  2. Christian Kuhn commented on patch set 1 CR -1 08/27/20, 12:21

    needs more work when calling module if in workspace ...
  3. TYPO3com voted on patch set 1 V +1 08/27/20, 12:36 Completed build in 15m 16s on Thu, 27 Aug, 12:36 PM Test Summary: 73092 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5009

  4. Christian Kuhn uploaded patch set 2 08/31/20, 10:10

  5. TYPO3com voted on patch set 2 V +1 08/31/20, 10:22 Completed build in 11m 09s on Mon, 31 Aug, 10:22 AM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5076

  6. Christian Kuhn uploaded patch set 3 03/12/21, 17:00

  7. TYPO3com voted on patch set 3 V +1 03/12/21, 17:08 Completed build in 07m 53s on Fri, 12 Mar, 05:08 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10091

  8. core-ci voted on patch set 3 V +1 03/12/21, 17:11 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1468

  9. Oliver Klee commented on patch set 3 03/12/21, 18:48

    Please let's reword the commit message title to describe the change, not the old behavior that is changed.
  10. Christian Kuhn updated the commit message in patch set 4 03/12/21, 21:07

  11. TYPO3com voted on patch set 4 V +1 03/12/21, 21:14 Completed build in 06m 56s on Fri, 12 Mar, 09:14 PM Test Summary: 32699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-10098

  12. Christian Kuhn commented on patch set 4 03/12/21, 21:16

    Reply

    do you have any suggestion? the patch drops this feature - how to rephrase?
  13. Christian Kuhn commented on patch set 4 03/12/21, 21:17

    Reply Unresolved

    ah, scratch that ... changed this already ... clicked wrong patch ^^
  14. core-ci voted on patch set 4 V +1 03/12/21, 21:18 Core CI is happy: https://core.b13.com/typo3-core/typo3.cms/-/pipelines/1475

  15. Oliver Klee wrote 03/12/21, 22:27

    Removed reviewer Oliver Klee.
  16. Oliver Klee commented on patch set 4 03/12/21, 22:27

    @Christian: Thanks!
  17. Anja Leichsenring voted on patch set 4 V +1 CR +1 03/14/21, 15:43

  18. Guido Schmechel voted on patch set 4 V +1 CR +1 03/14/21, 16:48

  19. Guido Schmechel commented on patch set 4 03/14/21, 16:49

    Short question: Bugfix for 10.4 isn't planned?
  20. Benni Mack voted on patch set 4 V +1 CR +1 03/14/21, 17:55

  21. Christian Kuhn commented on patch set 4 03/14/21, 18:09

    Reply

    I skipped v10 here: The backport is not trivial due to a different patch in master before - If anyone steps in, it could be done, but I personally wouldn't commit the effort to take care of the backport here if there is no huge pressure.
  22. Christian Kuhn voted on patch set 4 V +2 CR +2 03/14/21, 18:09

  23. Christian Kuhn merged patch set 5 03/14/21, 18:10