Review main Merged

65509[BUGFIX] Resolve translated pages below untranslated mount points

Xavier Perseguers CR +2 V +2 Normal +84 −3 updated 11/19/26, 09:53

Commit message

A mount point page without a translation is only found in a fallback
language of the requested language, e.g. the default language. The
pages of the mounted tree were then looked up in that fallback language
only, so their translations were never found and the URLs generated
for them, e.g. "/fr/archive/produits", ended in a "page not found".

The pages below a mount point are now looked up in all languages of
the fallback chain of the requested language, starting with the
requested language itself, and the mounted page is overlaid in each of
these languages to strip its slug prefix correctly.

As the language looked up may now differ from the language of the
mount point record, the check whether a candidate is connected to the
mount point determines the default language page id of the mount point
by the language of the record.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1719

  1. Xavier Perseguers uploaded patch set 1 08/31/20, 12:41

  2. TYPO3com voted on patch set 1 V +1 08/31/20, 12:52 Completed build in 11m 10s on Mon, 31 Aug, 12:52 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5089

  3. Oliver Klee commented on patch set 1 CR -1 08/31/20, 12:56

    And can we have tests for this?

    PageSlugCandidateProvider.php:190

    Can we make these more specific, e.g., int[]?

    PageSlugCandidateProvider.php:198

    I find the API very unintuitive now: We now can provide one language in one argument. Or one language in the other argument. Or one in both. Or one in the first and multiple in the second. Can we please streamline this and make it more intuitive how to use it?

    PageSlugCandidateProvider.php:308

    The existence of this comment alludes that the following code is too complex. Can we move it to a separate method, please?
  4. Oliver Klee commented on patch set 1 08/31/20, 12:57

    PageSlugCandidateProvider.php:194

    And why $languages and not $languageUids?
  5. Xavier Perseguers commented on patch set 1 08/31/20, 13:04

    PageSlugCandidateProvider.php:190 Reply

    for the same reason that $excludeUids is marked as array: mimetism

    PageSlugCandidateProvider.php:194 Reply

    no reasons, can naturally be changed

    PageSlugCandidateProvider.php:198 Reply

    dunno what you mean exactly.

    PageSlugCandidateProvider.php:308 Reply

    create yet another method to encapsulate a loop? euh... you can remove the comment if you think it is of no use.
  6. Benni Mack commented on patch set 1 11/12/21, 10:28

    Anybody willing to update the patch and continue here? I also agree with @Oli that tests would be really helpful.
  7. Benni Mack wrote 11/29/21, 10:13

    Change destination moved from master to main
  8. Benni Mack updated the commit message in patch set 2 11/29/21, 13:38

  9. Oliver Klee wrote 02/20/22, 11:38

    Removed reviewer Oliver Klee.
  10. Benni Mack updated the commit message in patch set 3 05/03/23, 09:15

  11. Benni Mack updated the commit message in patch set 4 10/18/24, 14:05

  12. Benni Mack marked it work in progress 01/31/25, 12:53

  13. Benni Mack uploaded patch set 5 11/12/26, 20:42

  14. Benni Mack commented on patch set 5 11/12/26, 20:44

    This change is ready for review.

    PageSlugCandidateProvider.php:190 Reply

    Done

    PageSlugCandidateProvider.php:194 Reply

    Done

    PageSlugCandidateProvider.php:198 Reply

    Done

    PageSlugCandidateProvider.php:308 Reply

    Done
  15. Benni Mack voted on patch set 5 CR +1 V +1 11/12/26, 20:45

  16. core-ci voted on patch set 5 V +1 11/12/26, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114229

  17. Simon Schaufelberger voted on patch set 5 CR +1 V +1 11/14/26, 20:11

  18. Benni Mack voted on patch set 5 CR +2 V +2 11/19/26, 09:53

  19. Benni Mack merged patch set 6 11/19/26, 09:53