65509[BUGFIX] Resolve translated pages below untranslated mount points
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
-
Verified V +2 Done
- Benni Mack +2
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1719
-
Xavier Perseguers uploaded patch set 1 08/31/20, 12:41
-
TYPO3com voted on patch set 1 V +1 08/31/20, 12:52 Completed build in 11m 10s on Mon, 31 Aug, 12:52 PM Test Summary: 73146 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5089
-
Oliver Klee commented on patch set 1 CR -1 08/31/20, 12:56
And can we have tests for this?PageSlugCandidateProvider.php:190Can we make these more specific, e.g., int[]?PageSlugCandidateProvider.php:198I find the API very unintuitive now: We now can provide one language in one argument. Or one language in the other argument. Or one in both. Or one in the first and multiple in the second. Can we please streamline this and make it more intuitive how to use it?PageSlugCandidateProvider.php:308The existence of this comment alludes that the following code is too complex. Can we move it to a separate method, please? -
Oliver Klee commented on patch set 1 08/31/20, 12:57
PageSlugCandidateProvider.php:194And why $languages and not $languageUids? -
Xavier Perseguers commented on patch set 1 08/31/20, 13:04
PageSlugCandidateProvider.php:190Replyfor the same reason that $excludeUids is marked as array: mimetismPageSlugCandidateProvider.php:194Replyno reasons, can naturally be changedPageSlugCandidateProvider.php:198Replydunno what you mean exactly.PageSlugCandidateProvider.php:308Replycreate yet another method to encapsulate a loop? euh... you can remove the comment if you think it is of no use. -
Benni Mack commented on patch set 1 11/12/21, 10:28
Anybody willing to update the patch and continue here? I also agree with @Oli that tests would be really helpful. -
Benni Mack wrote 11/29/21, 10:13
Change destination moved from master to main -
Benni Mack updated the commit message in patch set 2 11/29/21, 13:38
-
Oliver Klee wrote 02/20/22, 11:38
Removed reviewer Oliver Klee. -
Benni Mack updated the commit message in patch set 3 05/03/23, 09:15
-
Benni Mack updated the commit message in patch set 4 10/18/24, 14:05
-
Benni Mack marked it work in progress 01/31/25, 12:53
-
Benni Mack uploaded patch set 5 11/12/26, 20:42
-
Benni Mack commented on patch set 5 11/12/26, 20:44
This change is ready for review.PageSlugCandidateProvider.php:190ReplyDonePageSlugCandidateProvider.php:194ReplyDonePageSlugCandidateProvider.php:198ReplyDonePageSlugCandidateProvider.php:308ReplyDone -
Benni Mack voted on patch set 5 CR +1 V +1 11/12/26, 20:45
-
core-ci voted on patch set 5 V +1 11/12/26, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114229
-
Simon Schaufelberger voted on patch set 5 CR +1 V +1 11/14/26, 20:11
-
Benni Mack voted on patch set 5 CR +2 V +2 11/19/26, 09:53
-
Benni Mack merged patch set 6 11/19/26, 09:53