Review main Merged

65514[TASK] Execute frontend functional tests in sub request

Christian Kuhn CR +2 V +2 Expert +753 −737 updated 12/01/20, 14:09

Commit message

Constants TYPO3_MODE and TYPO3_REQUESTTYPE are unused
in core, and we have a new helper method in
typo3/testing-framework to execute sub requests.

The patch switches all functional tests that execute
frontend requests to use a sub request instead of
handling standalone PHP processes.

This patch is quite a milestone: It is the proof that
TYPO3 framework state can be managed well enough to
execute multiple TYPO3 application requests in one process.

As a happy little side effect, the overall performance
of the functional tests is increased by roughly 20
percent. This is quite a bit when considering the fact
that most execution time is consumed by setting up
all the database tables.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 55

Show 35 more files