Review 10.4 Merged

65556[TASK] Extract SVG image processing into processor

Helmut Hummel CR +2 V +2 Hard +518 −111 updated 09/12/20, 12:36

Commit message

Instead of spreading (similar) code that handles SVG
files in multiple classes with conditional code
branching, processing SVG files (mostly calculating
new width and height according to the configuration)
is now placed in an own file processor.

Cropping SVGs is still done like before using IM/GM
and resulting in an png image. In this case the new
processor is skipped and the file is passed to the
existing LocalImageProcessor.

A new class is introduced, which calculates resulting
image dimension from an original dimension and a given
processing task.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 10