Review 10.4 Merged

65588[TASK] CSV integrity test script can fix fixtures

Christian Kuhn CR +2 V +2 Nightmare +1750 −1622 updated 09/05/20, 12:26

Commit message

CSV fixture files are a straight way to feed test database
with stuff and to assert database state after operations.
Script Build/Scripts/checkIntegrityCsvFixtures.php tests those
files for integrity, making sure all lines have the same number
of columns. Maintaining the number of commas when fiddling with
functional tests however is annoying.

The patch adds options to checkIntegrityCsvFixtures.php:
* '--fix' simply fixes files with broken integrity
* '--fixAll' goes through all files and looks for details
  like superfluous comma.

While --fixAll is used once now to establish a good baseline
on all .csv fixtutre files, --fix can be used whenever the
integrity script mumbles about broken stuff:

Build/Scripts/checkIntegrityCsvFixtures.php --fix

It is also added to runTests.sh:

Build/Scripts/runTests.sh -s fixCsvFixtures

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 66

Show 46 more files