Review main Merged

65635[BUGFIX] Add support for symfony/event-dispatcher-contracts v1

Benni Mack CR +2 V +2 Easy +3 −3 updated 09/08/20, 20:21

Commit message

With the introduction of symfony/event-dispatcher-contracts
in https://git.typo3.org/Packages/TYPO3.CMS.git/commit/e4a1ae8762ee99712e4e5c9c2f8a3876bce97620

this change forced support for symfony5 in composer-based installations
(although non-composer-based installations use symfony5 bundled already),
as contracts v2 is only compatible with symfony v5, but contracts
v1 is used for symfony4.

This change allows composer-based installations to support both
versions (v5/v4) again, so extensions like EXT:solr (which requires
a package called solarium) to work with the dependency constraints
of TYPO3 Core.

- composer require "symfony/event-dispatcher-contracts:^1.1 || ^2.0" --no-update \
    --working-dir=typo3/sysext/core
- composer require "symfony/event-dispatcher-contracts:^1.1 || ^2.0" --no-update
- composer update --lock

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3