Review main Merged

65640[TASK] Make Argument and Arguments classes dependency free

Alexander Schnitzler CR +2 V +2 Normal +66 −168 updated 10/08/20, 10:58

Commit message

Classes Argument and Arguments are prototypes (stateful) which
have been created by the object manager to have dependencies
injected. This however is problematic for various reasons:

1) ObjectManager shouldn't be injected into classes as it's
   used to fetch objects (with DI support) directly from the
   container.
2) In those classes, prototypes had been injected which are now
   created directly via makeInstance.

To be able to achieve this, the property mapper had been pulled
out of the Argument class and does not longer manipulate the
internal value on a setValue call. The proper value is now set
from outside the Argument instances in the ActionController.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 6