Review main Merged

65648[BUGFIX] Revert "[BUGFIX] Add support for symfony/event-dispatcher-contracts v1"

Benjamin Franzke CR +2 V +2 Easy +3 −3 updated 09/09/20, 10:53

Commit message

This reverts commit e2b1148cef57d434ddda035da3d693f784a1e0f1.

Our Event dispatcher adapter is currently not compatible with
symfony/event-dispatcher-contracts:v1 (type declaration mismatch)
and therefore results in a runtime fatal error with symfony v4.

Compatibility with symfony v4 will be added in a new
revision of the reverted patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3