Review main Merged

6565[BUGFIX] Invalid query part on menu rendering

Oliver Hader CR +2 V +2 Easy +4 −1 updated 06/03/13, 20:49

Commit message

Each page can have a target defined, which can also be a
typeNum that gets added to the generated URL. Now if RealURL
is used, the "&type=" part will be just added to the final
URL which looks like "page.html&type=1". A question mark
is missing here to get a valid query part.

Review

  • Code review CR +2
    • Steffen Ritter +2
    • Stefan Neufeind +1
    • Simon Schaufelberger +1
    • Philipp Gampe +1
  • Verified V +2
    • Steffen Ritter +2
    • Philipp Gampe +1

Files 1

Review log 6

  1. Stefan Neufeind commented on patch set 1 11/28/11, 16:59

    Looks good to me, but someone else must approve I agree that ?& is "not nice" but it is still valid though.
  2. Steffen Ritter commented on patch set 1 V 0 11/28/11, 16:59

    by team member; Looks good to me, approved
  3. Philipp Gampe commented on patch set 1 11/28/11, 16:59

    Verified; Looks good to me, but someone else must approve Works ... however now it is ...link.html?&type=2. The "?&" is somehow strange - although not related to this bug.
  4. Simon Schaufelberger commented on patch set 1 11/28/11, 16:59

    Looks good to me, but someone else must approve
  5. Mr. Jenkins commented on patch set 1 11/28/11, 16:59

  6. Steffen Ritter merged patch set 1 11/28/11, 16:59