Review main Abandoned

65709[TASK] Revert "[TASK] Fix phpstan checkFunctionArgumentTypes errors in ext:core DependencyInjection"

Benjamin Franzke CR 0 V 0 Easy +4 −8 updated 10/06/20, 14:38

Commit message

This reverts commit d70c568a96d88b6bdbd7c7d98e75b293eef7911c.

Package argument of ServiceProviderRegistry::create()
was changed to PackageInterface, but the method
getServiceProvider() that is called on that argument
is not available on the interface, therefore
Package is declared as type by intent.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2