Review main Merged

65732[TASK] DatabaseRecordList: Drop tr's classes `firstcol` and `lastcol`

Daniel Windloff CR +2 V +2 Easy +0 −15 updated 09/17/20, 08:43

Commit message

The classes `firstcol` and `lastcol` for the first and last row of a
table were not used anymore. Therefore, they have been removed.

As the property `totalRowCount` was only used to set the class
`lastcol`, it also has been removed.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 78

  1. Daniel Windloff uploaded patch set 1 09/14/20, 03:10

  2. TYPO3com voted on patch set 1 V +1 09/14/20, 03:23 Completed build in 13m 22s on Mon, 14 Sep, 03:23 AM Test Summary: 73209 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5590

  3. Björn Jacob voted on patch set 1 CR +1 09/14/20, 08:05

  4. Georg Ringer commented on patch set 1 CR -1 09/14/20, 21:01

    please add a breaking rst and a check for the extension scanner. thanks
  5. Daniel Windloff commented on patch set 1 09/15/20, 07:50

    > Patch Set 1: Code-Review-1 > > please add a breaking rst and a check for the extension scanner. thanks I know, that the property is in the external section of the property list in the internal class. But the scope of the property is the table (like in foreach in generateList()) and not the class itself. Therefore, it doesn't make sense to use that property as API. That's why I would suggest to not add a breaking change here. Of course, if you consist, I'll add it.
  6. Georg Ringer commented on patch set 1 V +1 CR +1 09/15/20, 08:35

    ok fine for me
  7. Christian Kuhn voted on patch set 1 V +2 CR +2 09/17/20, 08:43

  8. Christian Kuhn merged patch set 2 09/17/20, 08:43