Review main Abandoned

65735[BUGFIX] Adjust handling of time values for native datetime fields

Thorben Nissen CR 0 V 0 Easy +14 −11 updated 07/04/23, 20:28

Commit message

Always apply datetime handling, when field has `dbType` set to a native
datetime field. Do not skip for empty values.

Only convert date string into timestamp. Do not apply conversion, if the
value already is an integer.

Use 0 (zero) as empty value instead of null.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 812

  1. Thorben Nissen uploaded patch set 1 09/14/20, 19:33

  2. TYPO3com voted on patch set 1 V +1 09/14/20, 19:44 Completed build in 11m 12s on Mon, 14 Sep, 07:44 PM Test Summary: 73238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5613

  3. Benni Mack updated the commit message in patch set 2 11/18/21, 10:36

  4. Benni Mack uploaded patch set 3 11/25/21, 20:50

  5. core-ci voted on patch set 3 V +1 11/25/21, 21:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/19763

  6. Benni Mack wrote 11/29/21, 10:20

    Change destination moved from master to main
  7. Benni Mack updated the commit message in patch set 4 11/29/21, 14:06

  8. core-ci voted on patch set 4 V +1 11/29/21, 18:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20085

  9. Simon Schaufelberger commented on patch set 4 06/13/22, 23:55

    @Torben, can you please write a test for this wrong behaviour?
  10. Benni Mack updated the commit message in patch set 5 V +1 05/03/23, 09:18

  11. core-ci voted on patch set 5 V -1 05/03/23, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41393

  12. Benni Mack abandoned the change 07/04/23, 20:28

    will abandon this change now due to lack of activity, can be restored later-on. The code does not match anymore and a few things are already fixed.