Review main Merged

65771[BUGFIX] Correct sys_refindex update on workspace publish

Christian Kuhn CR +2 V +2 Hard +350 −391 updated 09/20/20, 08:59

Commit message

When publishing workspace changes to live, many
sys_refindex rows are not updated properly, especially
if dealing with workspace-new or workspace-moved rows
and relations.

To update the reference index for relations, the data handler
uses class ReferenceIndex, which uses class RelationHandler,
which uses PlainDataResolver. All of these classes are
workspace aware and pick the current user workspace if
not explicitely told otherwise.

When publishing records, a given user is currently in some
workspace, but the reference index needs to be fixed for
live. This explicit runtime workspace switch is lost in
the ReferenceIndex.

The patch hands over given workspace context from
ReferenceIndex to RelationHandler during publish.

This one-liner fixes tons of broken reference index cases.
It also reveals a couple of still missing entries. Those
will be tackled with another patch.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 103

Show 83 more files