Review main Abandoned

65803[BUGFIX] Make getters of LazyLoadingProxy available for Fluid again

Stephan Großberndt CR 0 V 0 Normal +63 −1 updated 09/22/20, 12:27

Commit message

This patch makes AbstractDomainObject implement \ArrayAccess and load
the real Extbase Domain Model hidden behind a LazyLoadingProxy on
calling offsetGet(). This makes all magic getters of Extbase
Domain Models with @lazy annotation available for rendering in
Fluid again if they haven't been resolved yet, which is broken
since the removal of CmsVariableProvider in
TYPO3 v9.0 in https://review.typo3.org/c/Packages/TYPO3.CMS/+/53227

Fluid will only resolve the properties that are actually used in the
template, and only once - once resolved, the property value is
changed (because LazyLoadingProxy violates visibility and sets it on
the parent instance through forced reflection).

This is obviously also broken in v9.5 but will not be fixed there
anymore as the version only receives security relevant bugfixes.

Review

  • Code review CR 0

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V 0

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1