Review main Merged

65810[TASK] Local variable $resolvedIds in PlainDataResolver

Christian Kuhn CR +2 V +2 Easy +10 −19 updated 09/23/20, 08:21

Commit message

Protected class member $resolvedIds is only used
in get(), so it can be turned into a local variable.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Christian Kuhn uploaded patch set 1 09/22/20, 23:11

  2. Christian Kuhn updated the commit message in patch set 2 09/22/20, 23:15

  3. TYPO3com voted on patch set 1 V +1 09/22/20, 23:27 Completed build in 15m 48s on Tue, 22 Sep, 11:27 PM Test Summary: 73674 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5836

  4. TYPO3com voted on patch set 2 V +1 09/22/20, 23:32 Completed build in 14m 21s on Tue, 22 Sep, 11:31 PM Test Summary: 73675 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5837

  5. Georg Ringer voted on patch set 2 V +1 CR +1 09/23/20, 00:11

  6. Daniel Goerz commented on patch set 2 09/23/20, 06:59

    PlainDataResolver.php:140

    Looks like this was implemented like this as an internal cache. Doesn't that makes sense or is this only called once?
  7. Christian Kuhn commented on patch set 2 09/23/20, 07:22

    PlainDataResolver.php:140 Reply Unresolved

    All get() usages simply makeInstance->setters()->get() - so even if that variable was intended to be a local cache, it is not used as such. Wouldn't make sense to cache it anyway (depending on which exact input?)
  8. Benni Mack commented on patch set 2 V +2 CR +2 09/23/20, 08:21

    agree with Christian, this state looks unnecessarry based on the usages.
  9. Benni Mack merged patch set 3 09/23/20, 08:21