65960[BUGFIX] Use transOrigPointerField for indentation check in recordlist
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Christian Kuhn +1
-
Verified V +2 Done
- Georg Ringer +2
- Christian Kuhn +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1114
-
Oli Bartsch uploaded patch set 1 09/29/20, 18:31
-
TYPO3com voted on patch set 1 V +1 09/29/20, 18:44 Completed build in 12m 51s on Tue, 29 Sep, 06:44 PM Test Summary: 74734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-548
-
Oli Bartsch updated the commit message in patch set 2 09/29/20, 18:54
-
TYPO3com voted on patch set 2 V +1 09/29/20, 19:07 Completed build in 12m 55s on Tue, 29 Sep, 07:07 PM Test Summary: 74734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-549
-
Georg Ringer voted on patch set 2 V +1 CR +1 09/29/20, 19:40
-
Tymoteusz Motylewski commented on patch set 2 09/29/20, 20:10
Is this change relevant only for 10.4? Shouldnt it be targetted also for master and 9.5? -
Oli Bartsch commented on patch set 2 09/29/20, 20:47
> Patch Set 2: > > Is this change relevant only for 10.4? Shouldnt it be targetted also for master and 9.5? Master has another code base since #92133. There will be a separate patch as there is some more to fix (see: #92447). I actually thought about adding 9.5 but as it's in priority bugfix mode, I don't think this patch qualifies therefore. -
Christian Kuhn commented on patch set 2 10/02/20, 13:17
DatabaseRecordList.php:2375this actually still emits a php notice if 'transOrigPointerField' is not set for a table (had that idea with the master patch already, but did not check in detail) -
Oli Bartsch uploaded patch set 3 10/02/20, 13:26
-
Oli Bartsch commented on patch set 3 10/02/20, 13:30
DatabaseRecordList.php:2375ReplyDone -
TYPO3com voted on patch set 3 V +1 10/02/20, 14:11 Completed build in 38m 54s on Fri, 2 Oct, 02:11 PM Test Summary: 74734 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC104-558
-
Christian Kuhn voted on patch set 3 V +1 CR +1 10/02/20, 14:14
-
Georg Ringer voted on patch set 3 V +2 CR +2 10/02/20, 14:35
-
Georg Ringer merged patch set 4 10/02/20, 14:35