65992[FEATURE] Add `defaultValues` argument to newRecord ViewHelpers
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Oli Bartsch +1
-
Verified V +2 Done
- Georg Ringer +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/ViewHelpers/Link/NewRecordViewHelper.php3+23 −1
- typo3/sysext/backend/Classes/ViewHelpers/Uri/NewRecordViewHelper.php1+13 −1
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Fixtures/Link/NewRecordViewHelper/WithPidTableAndDefaultValue.htmlnew+3 −0
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Fixtures/Link/NewRecordViewHelper/WithPidTableAndDefaultValues.htmlnew+3 −0
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Fixtures/Uri/NewRecordViewHelper/WithPidTableAndDefaultValue.htmlnew+3 −0
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Fixtures/Uri/NewRecordViewHelper/WithPidTableAndDefaultValues.htmlnew+3 −0
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Link/NewRecordViewHelperTest.php+21 −6
- typo3/sysext/backend/Tests/Functional/ViewHelpers/Uri/NewRecordViewHelperTest.php+28 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-92462-AddOptionalDefaultValuesArgumentToNewRecordViewHelpers.rstnew+49 −0
Review log 2435
Show 710 earlier messages
-
Philipp Parzer uploaded patch set 1 10/01/20, 14:41
-
Mathias Brodala commented on patch set 1 CR -1 10/01/20, 14:44
Please add a feature RST.EditRecordViewHelper.php:75UnresolvedThis should be named "defaults" or "defaultValues". Don't repeat the errors of the past. ;-) -
Oli Bartsch commented on patch set 1 V -1 10/01/20, 14:54
defVals are only used for `new` not for an `edit` of a record. See e.g. `fields` (`columnsOnly`) which is only available in the EditRecordViewHelpers. -
TYPO3com voted on patch set 1 V +1 10/01/20, 14:54 Completed build in 12m 54s on Thu, 1 Oct, 02:54 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6123
-
Philipp Parzer uploaded patch set 2 10/01/20, 15:07
-
Philipp Parzer uploaded patch set 3 10/01/20, 15:13
-
TYPO3com voted on patch set 2 V +1 10/01/20, 15:26 Completed build in 18m 48s on Thu, 1 Oct, 03:26 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6124
-
TYPO3com voted on patch set 3 V +1 10/01/20, 15:32 Completed build in 15m 55s on Thu, 1 Oct, 03:32 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6125
-
Georg Ringer commented on patch set 3 CR -1 10/01/20, 16:29
please change the name to "defaultValues", no need to stick to ugly names for new APIsNewRecordViewHelper.php:95Unresolvedpls set 5th parameter to []NewRecordViewHelper.php:76Unresolvedpls set 5th parameter to [] -
Philipp Parzer uploaded patch set 4 10/01/20, 18:45
-
Oli Bartsch commented on patch set 4 V -1 10/01/20, 18:50
On it -
TYPO3com voted on patch set 4 V +1 10/01/20, 18:59 Completed build in 14m 34s on Thu, 1 Oct, 06:59 PM Test Summary: 73690 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6136
-
Oli Bartsch uploaded patch set 5 10/01/20, 21:05
-
Oli Bartsch voted on patch set 5 V +1 CR +1 10/01/20, 21:17
-
TYPO3com voted on patch set 5 V +1 10/01/20, 21:21 Completed build in 15m 39s on Thu, 1 Oct, 09:21 PM Test Summary: 73697 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6146
-
Georg Ringer commented on patch set 5 10/01/20, 21:22
NewRecordViewHelper.php:72can we have a nice example just as in the rst --- <be:link.newRecord table="tt_content" pid="17" defaultValues="{tt_content: {header: 'value'}} --- i like those a lot more because easier to understand and more real world -
Oli Bartsch commented on patch set 6 10/01/20, 21:22
Published edit on patch set 5. -
Oli Bartsch voted on patch set 6 V +1 CR +1 10/01/20, 21:22
-
Oli Bartsch commented on patch set 6 10/01/20, 21:27
NewRecordViewHelper.php:72Reply UnresolvedGeneral yes. Actually we then have to change all examples to be consistent in the class. Would suggest to do that in a separat patch. This could also include more such examples in other VHs as well. -
TYPO3com voted on patch set 6 V +1 10/01/20, 21:39 Completed build in 16m 36s on Thu, 1 Oct, 09:39 PM Test Summary: 73699 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6148
-
Georg Ringer voted on patch set 6 V +1 CR +1 10/01/20, 21:40
-
Mathias Brodala commented on patch set 6 CR +1 10/02/20, 06:45
I love what this has become. :-) -
Christian Kuhn commented on patch set 6 10/02/20, 18:58
Unresolved
typo in defaul-T-Values -
Christian Kuhn updated the commit message in patch set 7 10/02/20, 18:58
-
Christian Kuhn voted on patch set 7 V +1 CR +1 10/02/20, 18:58
-
Oli Bartsch voted on patch set 7 V +1 CR +1 10/02/20, 19:04
-
TYPO3com voted on patch set 7 V -1 10/02/20, 19:17 Completed build in 19m 12s on Fri, 2 Oct, 07:17 PM Test Summary: 1 of 74229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6224
-
TYPO3com commented on patch set 7 10/02/20, 19:27 Completed build in 48m 14s on Fri, 2 Oct, 07:27 PM Test Summary: 1 of 74229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6224
-
TYPO3com commented on patch set 7 10/02/20, 19:39 Completed build in 1h 29m 13s on Fri, 2 Oct, 07:39 PM Test Summary: 1 of 74229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6224
-
Christian Kuhn rebased onto patch set 8 10/02/20, 20:06
-
TYPO3com commented on patch set 7 10/02/20, 20:06 Completed build in 2h 37m 43s on Fri, 2 Oct, 08:06 PM Test Summary: 1 of 74229 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6224
-
TYPO3com voted on patch set 8 V +1 10/02/20, 20:29 Completed build in 20m 45s on Fri, 2 Oct, 08:29 PM Test Summary: 73743 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6227
-
Oli Bartsch voted on patch set 8 V +1 CR +1 10/02/20, 21:43
-
Georg Ringer voted on patch set 8 V +2 CR +2 10/03/20, 11:19
-
Georg Ringer merged patch set 9 10/03/20, 11:19