Review main Abandoned

65996[WIP][FEATURE] Simplify LanguageMenuProcessor

Georg Ringer CR 0 V 0 Hard +58 −394 updated 03/26/25, 16:13

Commit message

Simplify the languageMenuProcessor by calling the
MenuContentObjectFactory directly instead of building a full menu as
json.

Benefits:
- Faster
- Easier to read
- Providing additional data to the template:
  - full translated page row of
  - full language configuration

Todo:
- rst

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 1929

Show 24 earlier messages
  1. Georg Ringer uploaded patch set 1 10/01/20, 20:36

  2. TYPO3com voted on patch set 1 V -1 10/01/20, 20:40 Completed build in 25s on Thu, 1 Oct, 08:40 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6142

  3. Georg Ringer uploaded patch set 2 10/01/20, 20:45

  4. TYPO3com voted on patch set 2 V -1 10/01/20, 20:46 Completed build in 33s on Thu, 1 Oct, 08:46 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6143

  1. Georg Ringer uploaded patch set 3 10/01/20, 20:49

  2. TYPO3com voted on patch set 3 V -1 10/01/20, 21:04 Completed build in 15m 14s on Thu, 1 Oct, 09:04 PM Test Summary: 18 of 74175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6144

  3. Simon Gilli commented on patch set 3 10/01/20, 21:07

    Nice solution. We should make sure the whole functionality is covered by tests before continue here...

    LanguageMenuProcessor.php:85 Unresolved

    $this->menuConfig is not used later and this functionality seems to be removed.

    LanguageMenuProcessor.php:104 Unresolved

    $key is undefined, intended?
  4. Georg Ringer uploaded patch set 4 10/01/20, 21:18

  5. Georg Ringer uploaded patch set 5 10/01/20, 21:25

  6. TYPO3com voted on patch set 4 V -1 10/01/20, 21:30 Completed build in 11m 32s on Thu, 1 Oct, 09:30 PM Test Summary: 6 of 74175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6147

  7. TYPO3com voted on patch set 5 V -1 10/01/20, 21:46 Completed build in 17m 21s on Thu, 1 Oct, 09:46 PM Test Summary: 6 of 74175 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-6149

  8. Benni Mack wrote 11/29/21, 10:04

    Change destination moved from master to main
  9. Benni Mack updated the commit message in patch set 6 11/29/21, 13:22

  10. Georg Ringer uploaded patch set 7 12/09/21, 18:31

  11. core-ci voted on patch set 7 V -1 12/09/21, 18:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20883

  12. Georg Ringer uploaded patch set 8 12/09/21, 18:54

  13. core-ci voted on patch set 8 V -1 12/09/21, 18:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/20885

  14. Georg Ringer uploaded patch set 9 02/08/22, 17:10

  15. core-ci voted on patch set 9 V -1 02/08/22, 17:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/23218

  16. Georg Ringer rebased onto patch set 10 03/07/22, 21:33

  17. core-ci voted on patch set 10 V -1 03/07/22, 21:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/24694

  18. Oliver Hader commented on patch set 10 05/04/22, 09:06

    Side-note: Instead of keeping those array-structures, I think we should start introducing objects/models, that can be used both as arrays (legacy) or json-encoded. ... and that of course involves some more work, and would be a general thing for menus and menu-processors (menu, menu-section, menu-item, ...)
  19. Benni Mack commented on patch set 10 05/25/22, 19:26

    Can you update the change?
  20. Georg Ringer commented on patch set 10 05/25/22, 20:59

    This change is ready for review.
    yes
  21. Georg Ringer uploaded patch set 11 V -1 10/09/23, 17:51

  22. core-ci voted on patch set 11 V -1 10/09/23, 18:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47611

  23. Simon Schaufelberger commented on patch set 11 12/17/24, 19:09

    Unresolved

    @georg.ringer@gmail.com would you like to bring this again into a mergable state?
  24. Benni Mack marked it work in progress 01/24/25, 10:28

  25. Benni Mack abandoned the change 03/26/25, 16:13

    Change is almost 5 years old, last update was 3 years ago. No issue, will close this. Let's start over then.