Review main Merged Breaking

66066[!!!][FEATURE] Always initialize frontend groups after FE user

Benni Mack CR +2 V +2 Normal +99 −57 updated 10/19/20, 18:32

Commit message

In previous TYPO3 versions (due to historic reasons) the frontend
groups were always resolved within TSFE when a page and the
rootline was resolved.

However, this left the actual Frontend User, which is initialized
at the very beginning of a frontend request, in an incomplete state:
A user was (correctly) found and "logged in", but the groups were
resolved at a later point.

This was due to the fact that the Admin Panel allowed to
"include hidden records" which also considered fe_groups,
and thus be set later-on.

This change now moved the resolving of the groups (and setting
the right frontend.user aspect) right after the user resolving.

This means that the groups are now available much earlier, and not
bound to the TSFE instance anymore, allowing to use Middlewares much
more professionally without depending on TSFE for custom Routing / APIs.

Future options:
It would even be possible to filter out PageRouter pages that are
not available, which would make the Router itself faster.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 4